Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capability to have multiple beams #246

Merged
merged 8 commits into from
Dec 2, 2020
Merged

Capability to have multiple beams #246

merged 8 commits into from
Dec 2, 2020

Conversation

MaxThevenet
Copy link
Member

@MaxThevenet MaxThevenet commented Dec 1, 2020

This PR proposes changes to allow multiple beam species. This is done by creating class MultiBeam which is a container around all beam species. CI is done by adding a second beam in an existing test.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@MaxThevenet MaxThevenet added the component: beam About the beam species label Dec 1, 2020
src/Hipace.H Outdated Show resolved Hide resolved
src/Hipace.cpp Show resolved Hide resolved
Copy link
Member

@SeverinDiederichs SeverinDiederichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this capability!

@SeverinDiederichs SeverinDiederichs merged commit f5fc11e into development Dec 2, 2020
@SeverinDiederichs SeverinDiederichs deleted the multi branch December 2, 2020 20:46
@MaxThevenet MaxThevenet mentioned this pull request Mar 18, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: beam About the beam species
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants