Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable multiple plasma species #432

Merged
merged 11 commits into from
Mar 23, 2021
Merged

Enable multiple plasma species #432

merged 11 commits into from
Mar 23, 2021

Conversation

MaxThevenet
Copy link
Member

@MaxThevenet MaxThevenet commented Mar 18, 2021 •
edited
Loading

This PR adds the possibility to have multiple plasma species, typically 1 for the ions and 1 for the electrons. It is a copy of what PR #246 did for beam particles.

This PR is sufficient for tests to still pass (with 0 or 1 plasma species), but additional features are required to make it really usable:

  • Properly handle the charge and the mass of each species (currently the user can specify them, but they are not used).
  • Test the implementation with an ion motion simulation
  • Add an automated test

I think we can review and merge this PR, and add the other features/fixes in separate PRs.

@MaxThevenet MaxThevenet changed the title [WIP] Multiplasma Enable multiple plasma species Mar 18, 2021
@MaxThevenet MaxThevenet added the component: plasma About the plasma species label Mar 18, 2021
SeverinDiederichs
SeverinDiederichs approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@SeverinDiederichs SeverinDiederichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, this PR will need to be accompanied by a fix of the PhysConst problem.

We should keep in mind that the no_plasma option is mentioned in the documentation properly.

@MaxThevenet
Copy link
Member Author

should we merge that?

@SeverinDiederichs
Copy link
Member

Yes, go ahead please :)
I will add the proper update in the particle pusher soon.

@MaxThevenet MaxThevenet merged commit 832429e into development Mar 23, 2021
@MaxThevenet MaxThevenet deleted the multiplasma branch March 23, 2021 09:23
@SeverinDiederichs SeverinDiederichs mentioned this pull request Mar 24, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeverinDiederichs SeverinDiederichs SeverinDiederichs approved these changes

Assignees
No one assigned
Labels
component: plasma About the plasma species
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxThevenet @SeverinDiederichs