Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] openPMD: Handle fields with Guards #271

Closed
wants to merge 2 commits into from
Closed

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Dec 17, 2020

For the corner-case of enabling guards in m_F (through hipace.3d_on_host = 0), we need to copy the validbox data out before we can present contiguous memory for I/O.

To do:

  • GPU test is writing zero data with this patch (even for hipace.3d_on_host = 1)

Normal check list:

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@ax3l ax3l added the component: diagnostics About any types of diagnostics label Dec 17, 2020
{
// cut away guards
amrex::FArrayBox io_fab(mfi.validbox(), 1, amrex::The_Pinned_Arena());
io_fab.copy< amrex::RunOn::Host >(fab, fab.box(), icomp, mfi.validbox(), 0, 1);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something here is off in GPU runs

@SeverinDiederichs
Copy link
Member

SeverinDiederichs commented Dec 17, 2020

This PR works fine, however it is based on the broken PR #270, therefore I will close it here and re-opened it as #272. #270 was reverted in #273.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: diagnostics About any types of diagnostics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants