-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openPMD: Collective Open & Group Based #274
Conversation
I would propose to use the blowout_wake example. It is super fast and produces a blowout wake to see if the fields are correct. No fixes on the CPU side are required (there are some corner cases as input parameters, which are failing, but they should not affect I/O at all). @ax3l Do you agree on the approach? |
Sounds good - that works on my system. The only downside with the What do I need to pass to the input file to compute with/without guards? Adding |
Progress: the issue is not here but with openPMD-viewer. Will report back with findings. |
@SeverinDiederichs PR updated :)
To do:
openPMD-viewer bug report: openPMD/openPMD-viewer#299 |
Re-introduce writing to one file to avoid syncs. Write in parallel into one file, which we open collectively. This has the nice side-effect, that later iteration flushes can be performed as non-collective writes.
6932101
to
1546acb
Compare
Declare meta-data for 2D slice output as truly 2D in meta-data.
1546acb
to
28f3ab2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, with the new openPMD-viewer I can verify that it indeed works as intended 🎉 . The test we agreed on shows differences between CPUs and GPUs, but this is the bug on CPUs we discussed earlier (I will link the issue after I have opened it). For stricter predictor corrector loop settings, both CPU and GPU produce the same results. I have tested slice I/O, 3D IO, all with 1 and 5 ranks on both CPU and GPU.
Re-introduce writing to one file to avoid syncs #270 / #273 / #271 (comment)
Write in parallel into one file, which we open collectively.
This has the nice side-effect, that later iteration flushes can be performed as non-collective writes.
To Do:
blowout_wake
General:
const
isconst
)