Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: macOS w/ CTest #878

Closed
wants to merge 1 commit into from
Closed

CI: macOS w/ CTest #878

wants to merge 1 commit into from

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Mar 1, 2023

Enable CTest on macOS for runtime tests.

Follow-up to #874

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

Enable CTest on macOS for runtime tests.
@ax3l ax3l added the CI Continuous integration, checksum and analysis tests, GitHub Actions, etc. label Mar 1, 2023
@ax3l ax3l requested a review from MaxThevenet March 1, 2023 23:03
@MaxThevenet
Copy link
Member

MacOS is already often the most time-consuming test. Should we close this PR, and do run tests later if needed? Also, the workflow yml files have changed a bit.

@MaxThevenet
Copy link
Member

As this would significantly increase CI time, let's close the PR for now and re-open need comes.

@MaxThevenet MaxThevenet closed this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration, checksum and analysis tests, GitHub Actions, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants