Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: macOS #874

Merged
merged 8 commits into from
Mar 1, 2023
Merged

CI: macOS #874

merged 8 commits into from
Mar 1, 2023

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Feb 28, 2023

Add CI for macOS.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@ax3l
CI: macOS
d3c072a 
Add CI for macOS.
@ax3l ax3l added the CI Continuous integration, checksum and analysis tests, GitHub Actions, etc. label Feb 28, 2023
ax3l
ax3l commented Feb 28, 2023
View reviewed changes
.github/workflows/macos.yml Outdated Show resolved Hide resolved
ax3l
ax3l commented Feb 28, 2023
View reviewed changes
.github/workflows/macos.yml Outdated Show resolved Hide resolved
ax3l
ax3l commented Mar 1, 2023
View reviewed changes
.github/workflows/macos.yml Outdated Show resolved Hide resolved
ax3l
ax3l commented Mar 1, 2023
View reviewed changes
.github/workflows/macos.yml Outdated Show resolved Hide resolved
ax3l
ax3l commented Mar 1, 2023
View reviewed changes
.github/workflows/macos.yml Outdated Show resolved Hide resolved
@ax3l ax3l merged commit 804b1ae into Hi-PACE:development Mar 1, 2023
@ax3l ax3l deleted the ci-macos branch March 1, 2023 22:39
@ax3l ax3l added the build CMake, compilation, etc. label Mar 1, 2023
This was referenced Mar 1, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSinn AlexanderSinn AlexanderSinn left review comments

Assignees

@MaxThevenet MaxThevenet

Labels
build CMake, compilation, etc. CI Continuous integration, checksum and analysis tests, GitHub Actions, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ax3l @AlexanderSinn @MaxThevenet