Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: macOS Only One #881

Merged
merged 1 commit into from
Mar 2, 2023
Merged

CI: macOS Only One #881

merged 1 commit into from
Mar 2, 2023

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Mar 2, 2023 •
edited
Loading

Only one build for macOS CI is sufficient (#874).
Let's pick SP.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@ax3l
CI: macOS Only One
698a804 
Only one build for macOS CI is sufficient.
Let's pick SP.
@ax3l ax3l added performance optimization, benchmark, profiling, etc. CI Continuous integration, checksum and analysis tests, GitHub Actions, etc. labels Mar 2, 2023
@ax3l ax3l requested a review from MaxThevenet March 2, 2023 11:04
MaxThevenet
MaxThevenet approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@MaxThevenet MaxThevenet merged commit e84b46a into Hi-PACE:development Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxThevenet MaxThevenet MaxThevenet approved these changes

Assignees

@MaxThevenet MaxThevenet

Labels
CI Continuous integration, checksum and analysis tests, GitHub Actions, etc. performance optimization, benchmark, profiling, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ax3l @MaxThevenet