Update @types/jasmine to the latest version 🚀 #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
|
Issues with expect-Promises, maybe adding |
patrickrobrecht
approved these changes
Sep 14, 2017
janis-kra
pushed a commit
that referenced
this pull request
Sep 19, 2017
* develop: Adjust authRedirectUri in example hip-config.json to port 8080 chore(package): update codelyzer to version 3.2.0 (#652) chore(package): update jasmine-core to version 2.8.0 (#625) Update @types/jasmine to the latest version 🚀 (#621) Update webpack-dev-server; change port to 8080 chore(package): update rimraf to version 2.6.2 (#651) HIPCMS-812: Bugfixes in edit page component: cancel button bugfix + cleanup (#650) Only compile *.e2e-spect.ts files when running the e2e tests Fix for tests which work fine again (at least locally) Remove unused code in the authentication module left after switch to auth0 chore(package): update webpack-dev-server to version 2.8.0 HIPCMS-803: Filter mobile pages by type (#649) HIPCMS-809: Improvements for media (#645) iss-hipcms-797:create tags from edit exhibit page (#648) Iss hipcms 805 edit tag redirect (#647) Iss hipcms 765 change dialog into page (#646) HIPCMS-708 Add webpack configuration for development (#644) # Conflicts: # app/authentication/auth.service.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.5.54 of @types/jasmine just got published.
The version 2.5.54 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of @types/jasmine.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴