Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIPCMS-812: Bugfixes in edit page component #650

Merged
merged 3 commits into from
Sep 14, 2017
Merged

HIPCMS-812: Bugfixes in edit page component #650

merged 3 commits into from
Sep 14, 2017

Conversation

eschmidt1
Copy link
Contributor

@eschmidt1 eschmidt1 commented Sep 11, 2017 •
edited
Loading

  • Fixed a bug where clicking "cancel" or "save" in the Edit Page component would invariably navigate back to the Page List component, instead of taking the user to wherever they came from.
  • Component title now shows "(no title)" if the page has no title instead of an empty string.
  • Removed page id from title: the end user doesn't need to know the id.
  • Removed leftover code which is not needed now that Edit Page is no longer a dialog.
  • Fixed broken translations.
  • Some formatting and imports cleanup.

@patrickrobrecht patrickrobrecht merged commit 2e4e41a into develop Sep 14, 2017
@patrickrobrecht patrickrobrecht deleted the iss-hipcms-812-edit-page-cancel-bugfix branch September 14, 2017 14:56
janis-kra pushed a commit that referenced this pull request Sep 19, 2017
Merge branch 'develop' into iss-hipcms-784-create-user-invitation-form
06d84bc 
* develop:
  Adjust authRedirectUri in example hip-config.json to port 8080
  chore(package): update codelyzer to version 3.2.0 (#652)
  chore(package): update jasmine-core to version 2.8.0 (#625)
  Update @types/jasmine to the latest version 🚀 (#621)
  Update webpack-dev-server; change port to 8080
  chore(package): update rimraf to version 2.6.2 (#651)
  HIPCMS-812: Bugfixes in edit page component: cancel button bugfix + cleanup (#650)
  Only compile *.e2e-spect.ts files when running the e2e tests
  Fix for tests which work fine again (at least locally)
  Remove unused code in the authentication module left after switch to auth0
  chore(package): update webpack-dev-server to version 2.8.0
  HIPCMS-803: Filter mobile pages by type (#649)
  HIPCMS-809: Improvements for media (#645)
  iss-hipcms-797:create tags from edit exhibit page (#648)
  Iss hipcms 805 edit tag redirect (#647)
  Iss hipcms 765 change dialog into page (#646)
  HIPCMS-708 Add webpack configuration for development (#644)

# Conflicts:
#	app/authentication/auth.service.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickrobrecht patrickrobrecht patrickrobrecht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eschmidt1 @patrickrobrecht