Skip to content

Commit

Permalink
Merge pull request #18843 from Homebrew/formula_auditor-pkgconf-coretap
Browse files Browse the repository at this point in the history
formula_auditor: avoid `pkg-config` dependency in core tap
  • Loading branch information
ZhongRuoyu authored Dec 3, 2024
2 parents 2e78000 + a3ab1cb commit 18f5f85
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions Library/Homebrew/formula_auditor.rb
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,7 @@ def audit_deps

# we want to allow uses_from_macos for aliases but not bare dependencies.
# we also allow `pkg-config` for backwards compatibility in external taps.
# TODO: after migrating all `pkg-config` usage to `pkgconf`, do not allow `pkg-config` in core tap
if self.class.aliases.include?(dep.name) && !dep.uses_from_macos? && dep.name != "pkg-config"
if self.class.aliases.include?(dep.name) && !dep.uses_from_macos? && (dep.name != "pkg-config" || @core_tap)
problem "Dependency '#{dep.name}' is an alias; use the canonical name '#{dep.to_formula.full_name}'."
end

Expand Down

0 comments on commit 18f5f85

Please sign in to comment.