Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula_auditor: avoid pkg-config dependency in core tap #18843

Merged
merged 1 commit into from
Dec 3, 2024
Merged

formula_auditor: avoid pkg-config dependency in core tap #18843

merged 1 commit into from
Dec 3, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 28, 2024 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

As we should use the actual dependency pkgconf rather than the alias.

Almost ready:

MikeMcQuaid
MikeMcQuaid approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good when 🟢

@pheiduck
Copy link

@cho-m you might have to use the actual package name: pkgconf

@cho-m cho-m force-pushed the formula_auditor-pkgconf-coretap branch from daaf2a4 to a3ab1cb Compare December 3, 2024 02:47
@cho-m cho-m marked this pull request as ready for review December 3, 2024 02:47
@ZhongRuoyu ZhongRuoyu enabled auto-merge December 3, 2024 02:50
@ZhongRuoyu ZhongRuoyu merged commit 18f5f85 into master Dec 3, 2024
28 checks passed
@ZhongRuoyu ZhongRuoyu deleted the formula_auditor-pkgconf-coretap branch December 3, 2024 02:59
This was referenced Dec 19, 2024
Open
Merged
jiacai2050 pushed a commit to zigcc/zig-cookbook that referenced this pull request Dec 20, 2024
@chenrui333
chore: use pkgconf rather than pkg-config for brew builds (#73)
f631ef1 
right now, pkgconf is an alias for pkg-config, but it would be better to
be explicit about it.

relates to Homebrew/brew#18843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhongRuoyu ZhongRuoyu ZhongRuoyu approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cho-m @pheiduck @MikeMcQuaid @ZhongRuoyu