-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils/pypi: allow only updating extra_packages
#16753
Conversation
cc @alex @branchvincent @timsutton and @woodruffw who may be interested in this. |
I think this means that we could remove this: https://github.com/Homebrew/brew-pip-audit/blob/main/generate-prs.rb#L19-L20 It'd be able to automatically bump the python packages used by those formula, is that right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, thanks @cho-m!
That's my understanding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far! One tweak.
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @cho-m!
Should be possible now that Homebrew/brew#16753 is landed
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Goal of PR is to allow easier updating of Python resources for formulae that aren't Python packages. In future, may allow
brew bump
to automatically run this (currently not done for non-PyPI URLs).To give an example, the resources within the
python
formulaCurrent state:
With PR, need to add diff to get subsequent output: