Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypi_formula_mappings: update resources for python@3.12 #164606

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Feb 29, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Follow up to Homebrew/brew#16753 for python@3.12:

Before:

brew update-python-resources python@3.12
Error: Unable to determine metadata for "https://www.python.org/ftp/python/3.12.2/Python-3.12.2.tgz" because of a failure when running
`/opt/homebrew/opt/python@3.12/libexec/bin/python -m pip install -q --no-deps --dry-run --ignore-installed --report /dev/stdout https://www.python.org/ftp/python/3.12.2/Python-3.12.2.tgz`.
Please report this issue:
  https://docs.brew.sh/Troubleshooting

After:

brew update-python-resources python@3.12
==> Retrieving PyPI dependencies for "flit-core setuptools pip wheel"...
==> Retrieving PyPI dependencies for excluded ""...
==> Getting PyPI info for "flit-core==3.9.0"
==> Getting PyPI info for "pip==24.0"
==> Getting PyPI info for "setuptools==69.1.1"
==> Getting PyPI info for "wheel==0.42.0"
==> Updating resource blocks

Signed-off-by: Michael Cho <michael@michaelcho.dev>
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Feb 29, 2024
@cho-m
Copy link
Member Author

cho-m commented Feb 29, 2024

For older Pythons, it looks like they originally provided setup.py, so our script does work, i.e.

brew update-python-resources python@3.11
==> Retrieving PyPI dependencies for "https://www.python.org/ftp/python/3.11.8/Python-3.11.8.tgz flit-core setuptools pip wheel"...
==> Retrieving PyPI dependencies for excluded ""...
==> Getting PyPI info for "flit-core==3.9.0"
==> Getting PyPI info for "pip==24.0"
==> Excluding "python==3.12.2"
==> Getting PyPI info for "setuptools==69.1.1"
==> Getting PyPI info for "wheel==0.42.0"
==> Updating resource blocks

We can add the PR change to python@3.8 ... @3.11 if we want to avoid downloading Python source code.

@p-linnane p-linnane added this pull request to the merge queue Feb 29, 2024
@p-linnane
Copy link
Member

We can add the PR change to python@3.8 ... @3.11 if we want to avoid downloading Python source code.

This seems worthwhile.

Merged via the queue into master with commit 05e11fc Feb 29, 2024
15 checks passed
@p-linnane p-linnane deleted the pypi-python@3.12-update-resources branch February 29, 2024 18:46
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants