Make Sequoia supported #18296
Merged
Make Sequoia supported #18296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-linnane
approved these changes
Sep 9, 2024
fxcoudert
force-pushed
the
sequoia_rc
branch
2 times, most recently
from
a0485d0
to
5893597
Compare
carlocab
reviewed
Sep 9, 2024
carlocab
reviewed
Sep 9, 2024
MikeMcQuaid
approved these changes
Sep 10, 2024
carlocab
added a commit
that referenced
this pull request
Sep 11, 2024
…orted_release?` See discussion at #18296.
7 tasks
Bo98
approved these changes
Sep 11, 2024
MikeMcQuaid
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Thanks @fxcoudert for opening and @carlocab and @Bo98 for help getting this over the line!
MikeMcQuaid
force-pushed
the
sequoia_rc
branch
from
5893597
to
4ab19e0
Compare
|
@carlocab Some CI failures here related to GitHub runners; could you take a look? Thanks 🙇🏻 |
|
Yup, tests just need updating since the tests assume they follow |
We've decoupled the macOS versions there from `MacOSVersion#supported_release?`, so these tests need updating.
|
Pushed an update here. Not complete yet, but will get there soon. |
|
Great, thanks for this @carlocab! |
|
Huh, didn't expect tests to pass yet. Glad that's all that was needed. 🥳 Will fix up those test assumptions at some point. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS Sequoia RC has dropped, and release is near. This PR is open to discuss the timing (we need to coordinate the merge of this PR and make a new release soon/immediately after).
Companion PR: Homebrew/install#878