Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Sequoia runner, 🔪 Monterey #18314

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Deploy Sequoia runner, 🔪 Monterey #18314

merged 1 commit into from
Sep 13, 2024
+9 −8

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This will allow us to avoid the loss of bottles to Homebrew/core PRs.

@carlocab carlocab requested a review from Bo98 September 12, 2024 08:21
@carlocab carlocab force-pushed the sequoia-runner-for-bottled-formulae branch from 04baa50 to 9141bb0 Compare September 12, 2024 08:24
MikeMcQuaid
MikeMcQuaid approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carlocab! Unclear from the code but: we should only do this for Apple Silicon on Sequoia, not Intel. Intel bottles should only be manually dispatched and not added into the normal rotation.

@carlocab
Copy link
Member Author

we should only do this for Apple Silicon on Sequoia, not Intel. Intel bottles should only be manually dispatched and not added into the normal rotation.

Yes, already handled in

brew/Library/Homebrew/github_runner_matrix.rb

Line 184 in c5d09b4

next if macos_version > NEWEST_HOMEBREW_CORE_INTEL_MACOS_RUNNER

@MikeMcQuaid
Copy link
Member

@carlocab Great, thanks, ship away!

@fxcoudert
Copy link
Member

fxcoudert commented Sep 12, 2024 •
edited
Loading

Actually, I think we're in good shape now to deploy the ARM Sequoia runner on all homebrew-core PRs. We usually do it at around 60% of formulas bottled, and now we're at 57%. Moreover, we have relatively few breakages (and they're often easy to fix with clang flags) so it should be fine at this point.

I'd suggest making this unconditional, and stoping macOS 12 CI altogether.

@carlocab carlocab changed the title Deploy Sequoia runner for formulae with Sequoia bottles Deploy Sequoia runner, 🔪 Monterey Sep 12, 2024
@carlocab
Copy link
Member Author

Cool, will adjust. Note: may take me until tomorrow to refactor out test failures nicely. (Or I can hardcode more assumptions into tests if we're in a hurry.)

@carlocab carlocab force-pushed the sequoia-runner-for-bottled-formulae branch 2 times, most recently from 8dab515 to 4ee4abe Compare September 12, 2024 13:15
Bo98
Bo98 reviewed Sep 12, 2024
View reviewed changes
Library/Homebrew/global.rb Outdated Show resolved Hide resolved
@carlocab
Change default Homebrew/core CI runners
51c4421 
We will now build on Ventura (macOS 13) to Sequoia (macOS 15).

Runners for macOS 15-x86_64 will not be allocated by default due to a
lack of appropriate hardware.
@carlocab carlocab force-pushed the sequoia-runner-for-bottled-formulae branch from 4ee4abe to 51c4421 Compare September 12, 2024 14:06
Bo98
Bo98 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@Bo98 Bo98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll let you judge when best to merge this, bearing in mind 4.3.21 which dropped the "no bottle available" error for macOS 12 can take up to 24 hours to reach everyone (on default settings).

@carlocab
Copy link
Member Author

LGTM. I'll let you judge when best to merge this, bearing in mind 4.3.21 which dropped the "no bottle available" error for macOS 12 can take up to 24 hours to reach everyone (on default settings).

Cool, let's wait till tomorrow then

@MikeMcQuaid MikeMcQuaid merged commit 51b9200 into master Sep 13, 2024
27 checks passed
@MikeMcQuaid MikeMcQuaid deleted the sequoia-runner-for-bottled-formulae branch September 13, 2024 07:36
@dduugg
Copy link
Member

dduugg commented Sep 13, 2024

is this merge the cause of this job failure? https://github.com/Homebrew/brew/actions/runs/10854929440/job/30126441752?pr=18305

@dduugg dduugg mentioned this pull request Sep 13, 2024
Merged
@carlocab
Copy link
Member Author

carlocab commented Sep 13, 2024 •
edited
Loading

I think that'll have been #18296 and the latest tag. See changes to package/Distribution.xml.

@scpeters scpeters mentioned this pull request Sep 16, 2024
Merged
This was referenced Sep 23, 2024
Closed
Closed
Merged
pitrou pushed a commit to apache/arrow that referenced this pull request Sep 26, 2024
@kou
GH-44206: [CI][macOS] Drop support for macOS 12 (#44212)
80622fa 
### Rationale for this change

Homebrew dropped support for macOS 12 (Monterey): Homebrew/brew#18314

### What changes are included in this PR?

Use macOS 13 instead of macOS 12 as much as possible.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #44206

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
ice0 added a commit to synfig/synfig that referenced this pull request Oct 14, 2024
@ice0
ci(Github Actions): bump macOS version (12 Monterey ->13 Ventura)
4f28094 
Homebrew has stopped building Monterey bottles (Homebrew/brew#18314)
ice0 added a commit to synfig/synfig that referenced this pull request Oct 14, 2024
@ice0
ci(Github Actions): bump macOS version (12 Monterey -> 13 Ventura)
7232102 
Homebrew has stopped building Monterey bottles (Homebrew/brew#18314)
@ice0 ice0 mentioned this pull request Oct 14, 2024
Closed
ice0 added a commit to ice0/synfig that referenced this pull request Oct 17, 2024
@ice0
ci(Github Actions): bump macOS version (12 Monterey -> 13 Ventura)
0eedd4d 
Homebrew has stopped building Monterey bottles (Homebrew/brew#18314)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-linnane p-linnane p-linnane approved these changes

@fxcoudert fxcoudert fxcoudert approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

@Bo98 Bo98 Bo98 approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@carlocab @MikeMcQuaid @fxcoudert @dduugg @Bo98 @chenrui333 @p-linnane