Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning to ZeroNet ('0.5.7') current #36947

Closed
wants to merge 1 commit into from
Closed

Add versioning to ZeroNet ('0.5.7') current #36947

wants to merge 1 commit into from

Conversation

BenjaminHCCarr
Copy link
Contributor

The sha256 and version will change but the URL currently won't.

Unfortunately, I don't see a way to automate versioning as their own versioning is out of date: https://github.com/HelloZeroNet/ZeroNet/tags versus the target URLs on https://zeronet.io/

Though this slightly increases maintainer overhead considering it is a security/privacy app, I think a functioning sha is good.


After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if updating a cask:

The `sha256` and `version` will change but the `URL` currently won't.

Unfortunately, I don't see a way to automate versioning as their own versioning is out of date: https://github.com/HelloZeroNet/ZeroNet/tags versus the target URLs on https://zeronet.io/

Though this slightly increases maintainer overhead considering it is a security/privacy app, I think a functioning `sha` is good.
@commitay
Copy link
Contributor

Without an appcast that matches the current release this cannot be versioned.

If you still want this to be versioned you should contact the developers and get them to provide a versioned release.

@commitay commitay closed this Jul 25, 2017
@commitay commitay mentioned this pull request Jul 25, 2017
3 tasks
@BenjaminHCCarr
Copy link
Contributor Author

BenjaminHCCarr commented Jul 25, 2017

In that case we need to update the required stanzas: https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/all_stanzas.md

The only required are:
version
sha256
url
name
homepage


Appcast is a full on "Optional"

@BenjaminHCCarr
Copy link
Contributor Author

BenjaminHCCarr commented Jul 25, 2017

@github !?!?!?!??!!?! Locked me out..... @commitay @miccal

Your account has been flagged.
Because of that, your profile is hidden from the public. If you believe this is a mistake, contact support to have your account status reviewed.

I got "Flagged" / Locked / Private
Thinking it's @KeybaseIO related keybase/proofs#39

@commitay
Copy link
Contributor

I noticed that your account 404ed and all issues and PRs authored by you disappeared.

Not sure I understand what you mean by updating the required stanzas?

@BenjaminHCCarr
Copy link
Contributor Author

I understand that appcast makes automation much easier. but there are many cask
in /usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask/Casks we get:

tyr:/usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask/Casks (master) benc$ ls *.rb | wc
    3663    3663   51214
tyr:/usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask/Casks (master) benc$ grep -ci appcast *.rb | grep -c 1$
1991

So just about half of all Cask do not have an appcast.

@BenjaminHCCarr
Copy link
Contributor Author

BenjaminHCCarr commented Jul 25, 2017

Homebrew cask has never requeired the appcast stanza; it is an optional, see: https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/all_stanzas.md

Just under half our casks don't have one at all.

@commitay
Copy link
Contributor

I think this is a misunderstanding over my previous comment.

Without an appcast that matches the current release this cannot be versioned.

What I meant was this cask with the current download url cannot be versioned without an appcast.

If it had a versioned url we can use it doesn't necessarily need to have an appcast.

@BenjaminHCCarr
Copy link
Contributor Author

abuses pipes
tyr:/usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask/Casks (master) benc$ grep -ci appcast *.rb | grep 0$ | awk -F: '{print $1}' | xargs grep url | grep -v \#\{version | grep 0$ | awk -F: '{print $1}'

So yes, everything either has a versioned URL or an appcast.

And I understand the confusion you and I had about the nomenclature of the appcast stanza.

That sadly still leaves us with ~732 unverified casks.

  1. using no appcast
  2. using sha256 no_check

I understand this makes maintenance easier. But from an end user perspective it is frustrating. latest doesn't mean anything particularly if there is no auto_updates.

Maybe we should revisit mainlining: https://github.com/buo/homebrew-cask-upgrade

Which has made my user experience better; particularly with all of the moving-bits and re-orgs in the last year.

@commitay
Copy link
Contributor

Maybe we should revisit mainlining: https://github.com/buo/homebrew-cask-upgrade

See #29301 for discussion about why this won't happen.


That sadly still leaves us with ~732 unverified casks.

  1. using no appcast
  2. using sha256 no_check

A lot of these casks casks we quite simply cannot version as there is no appcast / changelog and no versioned downloads.

@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants