Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google-chrome binary shim for Google Chrome #47792

Closed
wants to merge 1 commit into from

Conversation

gibfahn
Copy link
Contributor

@gibfahn gibfahn commented May 28, 2018

Puts google-chrome in the path.

Refs: #18809

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Puts `google-chrome` in the path.

Refs: Homebrew#18809
@commitay
Copy link
Contributor

We don't add binary/shimscript to apps unless they are provided and/or recommended by upstream.

Thanks for the PR nonetheless!

@commitay commitay closed this May 28, 2018
@gibfahn
Copy link
Contributor Author

gibfahn commented May 28, 2018

We don't add binary/shimscript to apps unless they are provided and/or recommended by upstream.

What would be acceptable evidence of that? Google's Chrome package for Linux adds google-chrome to the path, and a few CLI tools expect it to be in the path because of that (e.g. cargo-web).

@commitay
Copy link
Contributor

commitay commented May 28, 2018

What would be acceptable evidence of that?

Upstream documentation or the app having a binary that is intended to be run via CLI e.g atom, libreoffice.

IIRC the docs for chrome recommend creating an alias if you need it.

Google's Chrome package for Linux adds google-chrome to the path

Yes this is standard on Linux but not on macOS. Basically we intend to match what a manual install would have.

@Homebrew Homebrew locked and limited conversation to collaborators Aug 3, 2018
@gibfahn gibfahn deleted the chrome-binary branch February 12, 2020 10:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants