Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flutter 1.5.4-hotfix.2 #63170

Closed
wants to merge 1 commit into from
Closed

Add flutter 1.5.4-hotfix.2 #63170

wants to merge 1 commit into from

Conversation

lutzroeder
Copy link
Contributor

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.
  • The submission is for a stable version or documented exception.

Additionally, if adding a new cask:

@vitorgalvao
Copy link
Member

This seems to be a CLI-only open-source tool. Please submit it first to Homebrew/core as a formula. Return here if not accepted (linking back to the pull request where it was refused).

This policy is documented in faq/rejected_casks:

The app is both open-source and CLI-only (i.e. it only uses the binary artifact). In that case, and in the spirit of deduplication, submit it first to Homebrew/core as a formula that builds from source. If it is rejected, you may then try again as a cask (link us to the issue so we can see the discussion and reasoning for rejection).

@gideongrinberg
Copy link

This seems to be a CLI-only open-source tool. Please submit it first to Homebrew/core as a formula. Return here if not accepted (linking back to the pull request where it was refused).

This policy is documented in faq/rejected_casks:

The app is both open-source and CLI-only (i.e. it only uses the binary artifact). In that case, and in the spirit of deduplication, submit it first to Homebrew/core as a formula that builds from source. If it is rejected, you may then try again as a cask (link us to the issue so we can see the discussion and reasoning for rejection).

This was submitted to Homebrew/core, but was rejected as it doesn't build from source. It should be accepted.

@vitorgalvao
Copy link
Member

@Gideon357 #78848.

@miccal miccal mentioned this pull request Aug 10, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants