Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter 1.9.1 #72679

Closed
wants to merge 1 commit into from
Closed

flutter 1.9.1 #72679

wants to merge 1 commit into from

Conversation

mofneko
Copy link
Contributor

@mofneko mofneko commented Nov 15, 2019

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.
  • Named the cask according to the [token reference].
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no [open pull requests] for the same cask.
  • Checked the cask was not [already refused].
  • Checked the cask is submitted to [the correct repo].

@vitorgalvao
Copy link
Member

Welcome, @mofneko.

In the future, please don’t change the structure of the template, it’s helpful.

It was already refused and you know it. Please don’t check the box if it isn’t true, explain it instead (the template tells you as much, at the top). That was confusing and took me a while to figure out.

Still refusing because it should be a formula that builds from source.

@anton-matosov
Copy link

image
from here https://flutter.dev/docs/get-started/install/macos#run-flutter-doctor
Is that the reason why flutter is not built from source and pre-built binaries are used?

@vitorgalvao
Copy link
Member

@anton-matosov I don’t see how that would be relevant. Homebrew isn’t compiled and also uses Google Analytics.

@cweagans
Copy link
Contributor

I looked into building flutter from source for Homebrew, and it's really painful. Building it by hand is kind of a PITA. Automating it is even more so. Can we revisit this?

@anton-matosov
Copy link

@vitorgalvao just checking if analytics has anything to do with it.

@lock lock bot added the outdated label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants