-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avrdude: update dependencies and head build #102264
Conversation
depends_on "hidapi" | ||
depends_on "libftdi0" | ||
depends_on "libhid" | ||
depends_on "libusb-compat" | ||
depends_on "libftdi" | ||
depends_on "libusb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build instructions mention using newer/maintained variants at https://github.com/avrdudes/avrdude/wiki/Building-AVRDUDE-for-macOS and https://github.com/avrdudes/avrdude/wiki/General-Build-Instructions though may need to check if feature-complete.
libusb
vslibusb-compat
hidapi
vslibhid
libftdi
vslibftdi0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BSD is GPL-compatible, so elftoolchain
should be fine.
depends_on "libelf" | ||
depends_on "libelf" => :build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this only uses libelf.a
(no dynamic lib in formula). Could also consider disabling ELF feature since not sure how to handle unmaintained libelf
. Was previously looking at elftoolchain
but not ideal to mix BSD license while elfutils
doesn't build on macOS. Upstream does have its own repo copy of libelf
but mainly for Windows build.
Formula/avrdude.rb
Outdated
if build.head? | ||
inreplace "bootstrap", /libtoolize/, "glibtoolize" | ||
system "./bootstrap" | ||
system "cmake", "-S", ".", "-B", "build", *std_cmake_args |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this only builds static lib. Was trying -DBUILD_SHARED_LIBS=ON
but hit some undefined symbols and haven't had time to debug it. Though, only using cmake
on HEAD since this is what upstream recommends while tarball only has autoconf files. So, may not be too important about libs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try -undefined dynamic_lookup
for undefined symbols.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
🤖 A scheduled task has triggered a merge. |
@cho-m You need to add back libusb-compat, if not many programmers will not be supported, so far only usbasp supports libusb-1.0.
Ref: |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?