Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avrdude: re-add libusb-compat #103964

Closed
wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jun 18, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

#102264 (comment)

Updated test to at least check for error message.

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's pass --sysconfdir to configure to avoid using an etc directory in the Cellar.

Not sure what the equivalent CMake option is, though. If their CMakeLists.txt uses GNUInstallDirs it should also be CMAKE_INSTALL_SYSCONFDIR.

@cho-m cho-m force-pushed the avrdude-readd-usbcompat branch from 046dc7b to 5426c4f Compare June 18, 2022 05:40
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Jun 18, 2022
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2022
@cho-m cho-m deleted the avrdude-readd-usbcompat branch September 18, 2022 06:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants