Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asuka: fix test #129715

Merged
merged 1 commit into from
Apr 29, 2023
Merged

asuka: fix test #129715

merged 1 commit into from
Apr 29, 2023

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This should fix the "invalid byte sequence in UTF-8" test failure seen in #128865. Logs: https://github.com/Homebrew/homebrew-core/actions/runs/4784368511/jobs/8509780504?pr=128865#step:7:1004

@ZhongRuoyu ZhongRuoyu added the CI-no-bottles Merge without publishing bottles label Apr 29, 2023
@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Apr 29, 2023
@ZhongRuoyu ZhongRuoyu mentioned this pull request Apr 29, 2023
Merged
1 task
@fxcoudert fxcoudert added this pull request to the merge queue Apr 29, 2023
Merged via the queue into Homebrew:master with commit 1b8a56d Apr 29, 2023
@ZhongRuoyu ZhongRuoyu deleted the asuka-test branch April 29, 2023 12:12
@github-actions github-actions bot added the outdated PR was locked due to age label May 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fxcoudert fxcoudert fxcoudert approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZhongRuoyu @fxcoudert