rust 1.69.0

[ZhongRuoyu]

Created with brew bump-formula-pr.

• resource blocks have been checked for updates.

[carlocab]

Seems to have failed fast despite CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. .

I guess this doesn't work as expected:

homebrew-core/.github/workflows/tests.yml

Line 492 in 11917de

fail-fast: ${{ !contains(github.event.pull_request.labels.*.name, 'CI-no-fail-fast') }}

[ZhongRuoyu]

I think it's because CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. was not added when github.event was captured.

[ZhongRuoyu]

Failures

• brew test --retry --verbose exa (Minitest::Assertion: Expected: "-N" Actual: "\e[38;5;244m-\e[32mN\e[0m"; logs)
• brew test --retry --verbose geph4 (Minitest::Assertion: Expected /Error:\ invalid\ username\ or\ password/ to match ...; logs): geph4 4.8.1 #130195
• brew link gfold (logs): coreutils, gfold: add conflict #129304
• brew install --build-from-source grin ("enum_(unnamed_at_CRoaring/roaring_h_7_1)" is not a valid Ident; logs): grin: switch to llvm@15 #130508
• brew install --build-from-source mitmproxy (cannot find type `StaticSecret` in crate `x25519_dalek` ; logs): mitmproxy: update PyPI resources #129874
• brew fetch --build-from-source --retry qsv (logs): qsv 0.101.0 #129848
• brew install --build-from-source roapi (failed to load source for dependency `connectorx` ; logs): fixed upstream in roapi/roapi@411d727 and should be available on next release
• brew install --build-from-source tremor-runtime (warning: type ascription is experimental; logs): tremor-runtime: fix for rust 1.69; use brewed deps #129863

Python-related failures

• brew install --build-from-source buku (SetuptoolsDeprecationWarning: Invalid version: '0.2.2rc1.devNone'.; logs): buku 4.8 #129347
• brew test --retry --verbose charm-tools (The 'pip<23,>=1.5.4' distribution was not found and is required by charm-tools; logs)
• brew install --build-from-source duplicity (error in dropbox setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Expected end or semicolon (after version specifier); logs)
• brew install --build-from-source dvc (error in kombu setup command: 'tests_require' must be a string or list of strings containing valid project/version requirement specifiers; Expected end or semicolon (after name and no valid version specifier); logs): superseded by dvc 2.55.0 #128229
• (13-x86_64) brew install --build-from-source lexicon (Could not find a version that satisfies the requirement packaging>=20.0 (from versions: none); logs)
• brew test --retry --verbose snapcraft (pkg_resources.ContextualVersionConflict: (setuptools 67.6.1 (/opt/homebrew/Cellar/snapcraft/7.3.1/libexec/lib/python3.11/site-packages), Requirement.parse('setuptools<66'), {'snapcraft'}); logs)
• brew install --build-from-source trezor-agent (error in ledgerblue setup command: 'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiers.; logs): trezor-agent: update resources #129345

Other platform-specific failures

• (arm64, 12-x86_64) brew test --retry --verbose asuka (ArgumentError: invalid byte sequence in UTF-8; logs): asuka: fix test #129715
• (13-x86_64, 13-arm64) brew install --build-from-source newsboat (error: call to undeclared function 'wget_wch'; logs): newsboat: fix build #129716
• (13-x86_64) brew test --retry --verbose observerward (Minitest::Assertion: Expected /swagger/ to match ...; logs): superseded by observerward 2023.4.27 #129468
• (x86_64) brew install --build-from-source watchman (Undefined symbols for architecture x86_64; logs): known issue; see rust 1.66.0 #118242 (comment)

Transient

• (11-x86_64) brew test --retry --verbose boringtun (Timeout::Error: execution expired; logs): boringtun: test #125501
• (11-arm64) brew install --build-from-source chatblade (failed to get successful HTTP response from `https://crates.io/api/v1/crates/pyo3-macros-backend/0.17.3/download`, got 503; logs)
• (12-arm64, 11-arm64) brew test --retry --verbose drill (thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ValueOutOfRangeResizeDisabled'; logs): existing upstream issue: Benchmark panics if endpoint which assigns a value times out fcsonline/drill#72
• (12-arm64) brew fetch --build-from-source --retry page (curl: (35) Recv failure: Connection reset by peer; logs)
• (13-x86_64) brew test --retry --verbose sslyze (full output): looks like a network issue

[ZhongRuoyu]

We should be good to ship this now. All Rust-related issues are identified (see checklist) and are either fixed or to be fixed after the merge.

Many issues don't seem to be related to the Rust upgrade (many of them seem to be caused by recent Python package upgrades instead), so they shouldn't block us from shipping the Rust release.

---

A note on the grin failure (warning: variable 'run_count' set but not used "enum_(unnamed_at_CRoaring/roaring_h_7_1)" is not a valid Ident) which I didn't comment on in the checklist: it is due to an unused variable and the -Wall flag. A simple fix would be ENV.append_to_cflags "-Wno-unused-but-set-variable". Update: it's actually due to an issue with bindgen (logs) and can be fixed by switching to llvm@15 temporarily. But this error comes from the croaring-sys crate, and aside from croaring, it seems to be vendoring lmdb as well (see https://github.com/mimblewimble/grin/blob/v5.1.2/Cargo.lock). It's not a blocker so I will have a closer look at it later this week.

[github-actions]

@ZhongRuoyu has requested bottles to be published to this PR.