-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grin: switch to llvm@15
#130508
grin: switch to llvm@15
#130508
Conversation
5dac766
to
80cda75
Compare
🤖 An automated task has requested bottles to be published to this PR. |
Sorry, still no linkage with |
Can we mock a Though, TBH, I don't mind just adding one to |
Yea, I'm currently working to add a |
no lmdb linkage
Needed for Homebrew#130508. Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase
I tried building this locally with the new |
Ah. There are two crates: https://github.com/mimblewimble/grin/blob/v5.1.2/Cargo.lock#L1467 And unfortunately, https://github.com/vhbit/lmdb-rs/blob/master/liblmdb-sys/build.rs |
A follow-up to Homebrew#128865. The error '"enum_(unnamed_at_CRoaring/ roaring_h_7_1)" is not a valid Ident' was from `croaring`, caused by rust-lang/rust-bindgen#2312. We could fix this by switching to `llvm@15`.
llvm@15
; use brewed lmdb
llvm@15
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?A follow-up to #128865. The error '"enum_(unnamed_at_CRoaring/ roaring_h_7_1)" is not a valid Ident' was from
croaring
, caused by rust-lang/rust-bindgen#2312. We could fix this by switching tollvm@15
.In addition, add(Update: see #130508 (comment).)lmdb
as a dependency to avoid vendoring.croaring
is being vendored too, but the cratecroaring-sys
only supports building its own copy (see 1). Given that it's lightweight (with a single C source file), I think we can leave it as-is for now.Footnotes
https://github.com/saulius/croaring-rs/blob/0.8.1/croaring-sys/build.rs ↩