Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmdb: add lmdb.pc #130515

Merged
merged 2 commits into from
May 9, 2023
Merged

lmdb: add lmdb.pc #130515

merged 2 commits into from
May 9, 2023

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Needed for #130508.

Formula/lmdb.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label May 9, 2023
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label May 9, 2023
@ZhongRuoyu
Copy link
Member Author

Ok, here's another problem: lmdb-sys's build.rs seems to be calling pkg-config liblmdb, not lmdb: https://github.com/danburkert/lmdb-rs/blob/c64f0b4f8280190525a6430388e714739f18976b/lmdb-sys/build.rs#L13

Should we add a symlink here? Or we could also add a workaround on grin's side.

@carlocab
Copy link
Member

carlocab commented May 9, 2023

Just add a symlink I think.

Needed for Homebrew#130508.

Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
carlocab
carlocab previously approved these changes May 9, 2023
@carlocab
Copy link
Member

carlocab commented May 9, 2023

ARM64 dependent tests seems stuck. This shouldn't affect any dependents, so I think we're good to merge this.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

⚠️ @carlocab bottle publish failed. CC @carlocab

@github-actions github-actions bot dismissed carlocab’s stale review May 9, 2023 07:12

bottle publish failed

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 9, 2023
@BrewTestBot BrewTestBot enabled auto-merge May 9, 2023 07:16
@BrewTestBot BrewTestBot added this pull request to the merge queue May 9, 2023
Merged via the queue into Homebrew:master with commit 001459d May 9, 2023
@ZhongRuoyu ZhongRuoyu deleted the lmdb-pkg-config branch May 9, 2023 07:31
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants