Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tremor-runtime: fix for rust 1.69; use brewed deps #129863

Merged
merged 2 commits into from
May 9, 2023
Merged

tremor-runtime: fix for rust 1.69; use brewed deps #129863

merged 2 commits into from
May 9, 2023

Conversation

ZhongRuoyu
Copy link
Member

@ZhongRuoyu ZhongRuoyu commented May 1, 2023 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This should fix the error "log_error isn't a valid #[macro_export] argument" seen in #128865. Logs: https://github.com/Homebrew/homebrew-core/actions/runs/4784368511/jobs/8509780504?pr=128865#step:7:10764

I will upstream this if it works. Done.

@ZhongRuoyu ZhongRuoyu added the CI-no-bottles Merge without publishing bottles label May 1, 2023
@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label May 1, 2023
This was referenced May 1, 2023
Merged
Merged
@ZhongRuoyu
Copy link
Member Author

ZhongRuoyu commented May 1, 2023 •
edited
Loading

Linux failure:

    thread 'main' panicked at '"OnigValue_struct_(unnamed_at_oniguruma/src/oniguruma_h_783_3)" is not a valid Ident', /github/home/.cache/Homebrew/cargo_cache/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.39/src/fallback.rs:700:9

This could be fixed by switching to llvm@15 or upgrading bindgen.

In addition, it's vendoring oniguruma, librdkafka, openssl, et al. See https://github.com/tremor-rs/tremor-runtime/blob/v0.12.4/Cargo.lock.

@ZhongRuoyu ZhongRuoyu added the build failure CI fails while building the software label May 1, 2023
@ZhongRuoyu ZhongRuoyu marked this pull request as draft May 1, 2023 17:19
@ZhongRuoyu ZhongRuoyu force-pushed the tremor-runtime-fix branch from 7a5b5df to 6004937 Compare May 8, 2023 22:36
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label May 8, 2023
@ZhongRuoyu ZhongRuoyu force-pushed the tremor-runtime-fix branch 2 times, most recently from 56423ce to 2d32dce Compare May 9, 2023 03:14
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label May 9, 2023
@ZhongRuoyu ZhongRuoyu force-pushed the tremor-runtime-fix branch 2 times, most recently from a01aeec to 19e6d85 Compare May 9, 2023 03:20
@ZhongRuoyu ZhongRuoyu changed the title tremor-runtime: fix for rust 1.69 tremor-runtime: fix for rust 1.69; use brewed deps May 9, 2023
@ZhongRuoyu ZhongRuoyu removed build failure CI fails while building the software CI-no-bottles Merge without publishing bottles labels May 9, 2023
@ZhongRuoyu ZhongRuoyu marked this pull request as ready for review May 9, 2023 03:20
@ZhongRuoyu ZhongRuoyu force-pushed the tremor-runtime-fix branch 3 times, most recently from 6572b65 to 9629f46 Compare May 9, 2023 04:30
@ZhongRuoyu
tremor-runtime: fix for rust 1.69; use brewed deps
b8bd85e 
Apply a patch for the error "`log_error` isn't a valid `#[macro_export]`
argument" seen in Homebrew#128865. Logs:
  https://github.com/Homebrew/homebrew-core/actions/runs/4784368511/jobs/8509780504?pr=128865#step:7:10764

In addition, use brewed dependencies instead of vendored ones, when
possible.
@ZhongRuoyu ZhongRuoyu force-pushed the tremor-runtime-fix branch from 9629f46 to b8bd85e Compare May 9, 2023 05:23
@ZhongRuoyu ZhongRuoyu added the ready to merge PR can be merged once CI is green label May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 9, 2023
@BrewTestBot BrewTestBot enabled auto-merge May 9, 2023 07:57
@BrewTestBot BrewTestBot added this pull request to the merge queue May 9, 2023
Merged via the queue into Homebrew:master with commit 393d2be May 9, 2023
@ZhongRuoyu ZhongRuoyu deleted the tremor-runtime-fix branch May 9, 2023 08:13
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZhongRuoyu @SMillerDev @BrewTestBot