Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql@5.7: switch to openssl@3 #134421

Closed
wants to merge 1 commit into from
Closed

mysql@5.7: switch to openssl@3 #134421

wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

See #134251.

@carlocab carlocab added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 21, 2023
@github-actions github-actions bot added legacy Relates to a versioned @ formula formula deprecated Formula deprecated labels Jun 21, 2023
@Bo98
Copy link
Member

Bo98 commented Jun 21, 2023

5.7 EOL is October.

@p-linnane p-linnane mentioned this pull request Jun 21, 2023
Closed
@chenrui333 chenrui333 mentioned this pull request Jun 22, 2023
Closed
@chenrui333
Copy link
Member 

  -- 
  Cannot find appropriate system libraries for WITH_SSL=yes.
  Make sure you have specified a supported SSL version. 
  Valid options are : 
  system (use the OS openssl library), 
  yes (synonym for system), 
  </path/to/custom/openssl/installation>
  
  CMake Error at cmake/ssl.cmake:63 (MESSAGE):
    Please install the appropriate openssl developer package.
  
  Call Stack (most recent call first):
    cmake/ssl.cmake:306 (FATAL_SSL_NOT_FOUND_ERROR)
    CMakeLists.txt:603 (MYSQL_CHECK_SSL)

@chenrui333 chenrui333 added the build failure CI fails while building the software label Jun 23, 2023
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jun 23, 2023
@Bo98
Copy link
Member

Bo98 commented Jun 23, 2023

The patch is likely not trivial, judging by the 8.0 patch: mysql/mysql-server@a0132f5 (+ several follow up fix commits)

@fel1x-developer fel1x-developer mentioned this pull request Jun 24, 2023
Merged
@chenrui333
Copy link
Member

I think we can just close the PR as wont do

@carlocab carlocab closed this Jun 26, 2023
@carlocab carlocab deleted the mysql57-openssl3 branch June 26, 2023 15:06
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jun 26, 2023
@carlocab
versioned_dependencies_conflicts_allowlist: update
582a6f5 
I've removed formulae that are no longer needed (see Homebrew#135023), and added
formulae that will either never support `openssl@3` or look likely to
take a lot more time to migrate.

See:

- abricate Homebrew#134408
- dafny Homebrew#134593
- mariadb@10.4 Homebrew#134675
- mysql@5.7 Homebrew#134421
- root Homebrew#134838
- sslyze Homebrew#134599
@carlocab carlocab mentioned this pull request Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. formula deprecated Formula deprecated legacy Relates to a versioned @ formula openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlocab @Bo98 @chenrui333