Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sslyze: switch to openssl@3 #134599

Closed
wants to merge 2 commits into from
Closed

sslyze: switch to openssl@3 #134599

wants to merge 2 commits into from

Conversation

chenrui333
Copy link
Member

See #134251.

@chenrui333 chenrui333 added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 22, 2023
@github-actions github-actions bot added python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Jun 22, 2023
@chenrui333 chenrui333 mentioned this pull request Jun 22, 2023
Closed
@chenrui333
Copy link
Member Author 

         nassl._nassl.OpenSSLError: error:1006706B:elliptic curve routines:ec_GFp_simple_oct2point:point is not on curve
  error:1408D132:SSL routines:ssl3_get_key_exchange:bad ecpoint

@chenrui333 chenrui333 added test failure CI fails while running the test-do block 13-arm64 Ventura arm64 is specifically affected labels Jun 23, 2023
@carlocab carlocab added 13 Ventura is specifically affected and removed 13-arm64 Ventura arm64 is specifically affected labels Jun 23, 2023
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jun 26, 2023
@carlocab
versioned_dependencies_conflicts_allowlist: update
582a6f5 
I've removed formulae that are no longer needed (see Homebrew#135023), and added
formulae that will either never support `openssl@3` or look likely to
take a lot more time to migrate.

See:

- abricate Homebrew#134408
- dafny Homebrew#134593
- mariadb@10.4 Homebrew#134675
- mysql@5.7 Homebrew#134421
- root Homebrew#134838
- sslyze Homebrew#134599
@carlocab carlocab mentioned this pull request Jun 26, 2023
Merged
@p-linnane p-linnane changed the base branch from openssl-migration-staging to master June 26, 2023 23:55
@p-linnane p-linnane removed the staging-branch-pr This pull request targets a *-staging branch. label Jun 26, 2023
@carlocab carlocab mentioned this pull request Jul 1, 2023
Closed
13 tasks
@chenrui333 @carlocab
sslyze: switch to openssl@3
abf70b4 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 4, 2023
@cho-m
Copy link
Member

cho-m commented Jul 4, 2023

Added deparallelize as the linker failure from previous run looked to be parallelization issue when building the older bundled OpenSSL (1.0/1.1).

The test failure for Intel Ventura is still odd. I don't think it is due to openssl@3 as nassl uses the bundled OpenSSL. Seems strange that it is the only failure while all other macOS (like ARM Ventura) pass.

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jul 26, 2023
@github-actions github-actions bot closed this Aug 2, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 7, 2023
Closed
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2023
@chenrui333 chenrui333 deleted the sslyze-openssl3 branch January 22, 2024 15:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
13 Ventura is specifically affected autosquash Automatically squash pull request commits according to Homebrew style. openssl-3-migration Related to switching to an OpenSSL 3 dependency outdated PR was locked due to age python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue stale No recent activity test failure CI fails while running the test-do block
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenrui333 @cho-m @carlocab @p-linnane