-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gstreamer: add linbice dependency #161361
Conversation
a2baccf
to
722c0cd
Compare
The caveats addition is necessary because that's actually the real GStreamer plugin path. Otherwise, GStreamer will load plugins from the Cellar path instead and, for example, it won't load the gstreamer plugin that comes in |
722c0cd
to
1fe0f07
Compare
This enables the nice plugins and also adds the webrtcbin plugins from gst-plugins-bad. Note, that this is different from the disabled libnice subproject. The subproject clones libnice and try to install it in the system, which we don't want. In contrast, adding the dependency just allows plugins to depend on the system installed one.
1fe0f07
to
23564bd
Compare
@chenrui333 any chance to add the Btw, I'm also working on a current issue. Basically lots of GStreamer plugins are broken (at least on Apple Silicon), try for example:
This is now fixed here: https://gitlab.freedesktop.org/gstreamer/orc/-/merge_requests/163. Once this is merged, I believe they will release a new ORC version. After that we will need a new revision of GStreamer to compile orc files with the new ORC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libnice
depends on gstreamer
, so this creates a circular dependency (which we can't have).
Also, setting GST_PLUGIN_SYSTEM_PATH
seems to be discouraged by upstream maintainers. See #120206.
Should we create a |
I'll give that a try... |
Closing for now until I have something working locally. |
This enables the nice plugins and also adds the webrtcbin plugins from gst-plugins-bad.
Note, that this is different from the disabled libnice subproject. The subproject clones libnice and try to install it in the system, which we don't want. In contrast, adding the dependency just allows plugins to depend on the system installed one.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?