Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift-format 510.0.1 #166313

Closed

Conversation

emauricio
Copy link
Contributor

Created with brew bump-formula-pr.

@github-actions github-actions bot added swift Swift use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Mar 16, 2024
@emauricio
Copy link
Contributor Author

Hello there, I need a little help flagging this one
#166269

same changes but i closed because bump_pr failed to created the PR due to the repo being https instead ssh, and pushing it manually did not work.

thank you.

@Bo98
Copy link
Member

Bo98 commented Mar 16, 2024

There's some issues with this release in that it is actually missing some things added in 509.0.0: swiftlang/swift-format#697 (comment). Might be worth waiting to see what the outcome of that is.

@emauricio
Copy link
Contributor Author

@Bo98 seems they are working on the patch already,
swiftlang/swift-format#704

I got lucky and the version 5.10 works fine for me, but you are right, if they will release a patch soon waiting a bit is better.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Mar 19, 2024
@chenrui333
Copy link
Member

@Bo98 seems they are working on the patch already, apple/swift-format#704

I got lucky and the version 5.10 works fine for me, but you are right, if they will release a patch soon waiting a bit is better.

should we just close this PR?

@github-actions github-actions bot removed the stale No recent activity label Mar 19, 2024
@emauricio
Copy link
Contributor Author

emauricio commented Mar 20, 2024

@chenrui333 i created a new one,
#166666

sorry for the trouble.

@emauricio emauricio closed this Mar 20, 2024
@emauricio emauricio deleted the bump-swift-format-510.0.1 branch March 20, 2024 00:48
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` outdated PR was locked due to age swift Swift use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants