Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.10] Add fixes that were present in 509.0.0 but not release/5.10 #704

Merged
merged 19 commits into from
Mar 19, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Mar 16, 2024

mlavergn and others added 19 commits March 16, 2024 06:00
Extends the configuration options to allow disabling the addtion of trailing commas on multi-line collections.
…iteral array init

Instead of using an archaic initializer call syntax, let's replace
it with an empty array literal with a type annotation (if there isn't one).
Like with `some/any` type sugar, when we simplify an `Optional` whose
type parameter is an attributed type, we need to wrap it in parentheses
so that the `?` doesn't bind with the contained type.

Fixes swiftlang#657.
@ahoppen
Copy link
Member Author

ahoppen commented Mar 17, 2024

✅ Cross-repo testing from swiftlang/swift-syntax#2201 passed.

Copy link
Member

@allevato allevato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahoppen ahoppen merged commit 3191b8f into swiftlang:release/5.10 Mar 19, 2024
@ahoppen ahoppen deleted the ahoppen/5.10/cherry-picks branch March 19, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants