Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnu-getopt: change keg_only reason as macOS has BSD getopt #183637

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 5, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

On Linux, it usually makes more sense to use a general util-linux, which is how getopt is usually shipped in distros (rather than split packaged), e.g.

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Sep 5, 2024
@cho-m cho-m changed the title gnu-getopt: keg reason to shadowed as macOS has BSD getopt gnu-getopt: change keg_only reason as macOS has BSD getopt Sep 5, 2024
@cho-m cho-m added the CI-skip-dependents Pass --skip-dependents to brew test-bot. label Sep 6, 2024
@fxcoudert
Copy link
Member

Makes sense to me, thanks!

@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 6, 2024
Merged via the queue into master with commit 9541e41 Sep 6, 2024
24 of 30 checks passed
@BrewTestBot BrewTestBot deleted the gnu-getopt-shadowed branch September 6, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants