Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bc-gh 7.0.1 (new formula) #183679

Merged
merged 2 commits into from
Sep 6, 2024
Merged

bc-gh 7.0.1 (new formula) #183679

merged 2 commits into from
Sep 6, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 6, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This is bc included on recent macOS:

/usr/bin/bc --version
bc 6.5.0
Copyright (c) 2018-2023 Gavin D. Howard and contributors
Report bugs at: https://git.gavinhoward.com/gavin/bc

This is free software with ABSOLUTELY NO WARRANTY.

Since GNU bc has name, I just went with the common Repology name https://repology.org/project/bc-gh/versions which is:

We could go with bc-gavin or bc-gavinhoward though there is no one else using those names and seems better to go with upstream recommendation.

We could append suffix -gh to binaries via ENV["EXECSUFFIX"] = "-gh". Though we usually don't do this unless dealing with GNU g prefix to usually avoid BSD equivalents on macOS. Suffixed commands also are less useful given scripts usually just looking for bc/dc commands.

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Sep 6, 2024
@cho-m cho-m added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Sep 6, 2024
@cho-m cho-m force-pushed the bc-gh branch 3 times, most recently from bed53aa to 3cd13f2 Compare September 6, 2024 03:33
Copy link
Contributor

github-actions bot commented Sep 6, 2024

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 6, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 6, 2024
Merged via the queue into master with commit 4d5c116 Sep 6, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bc-gh branch September 6, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants