Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse 5.0.2 (new formula) #206845

Closed
wants to merge 5 commits into from
Closed

reuse 5.0.2 (new formula) #206845

wants to merge 5 commits into from

Conversation

toobuntu
Copy link
Contributor

@toobuntu toobuntu commented Feb 7, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Feb 7, 2025
@toobuntu
Copy link
Contributor Author

toobuntu commented Feb 7, 2025

livecheck seems to be returning 47 git tags, some of which do not appear in any GitHub release. If a livecheck block is therefore needed, I tried a few alternatives. There are 18 GitHub releases, one of which is a prerelease.

  • To avoid a github-* strategy, I tried page_match. Though, I'm not sure if readthedocs is an appropriate source. The problem is it gives only 12 results.

    livecheck do
     url "https://app.readthedocs.org/projects/reuse/"
     # Do not append `([a-z]+\d*)?` as it would match prereleases
     regex(/href=.*?\?version__slug=v?(\d+(?:\.\d+)+)/i)
    end
  • github_latest strategy seems to work fine, and returns only the latest release.

  • github_releases gives 17 results, as expected because one of the 18 is a prerelease.

  • Maybe use https://pypi.org/rss/project/reuse/releases.xml? I haven’t tried that one yet. Is it an appropriate source? I’m not sure how to exclude the prerelease or yanked release from that feed. There doesn’t seem to be metadata about those. And there’s also >18 on the list, so it doesn’t match the GitHub repo.

Should a github_latest livecheck block be added?

@toobuntu toobuntu marked this pull request as draft February 8, 2025 00:07
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Feb 8, 2025
@SMillerDev
Copy link
Member

Continues in #206960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosquash Automatically squash pull request commits according to Homebrew style. new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants