Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse 5.0.2 (new formula) #206960

Merged
merged 2 commits into from
Feb 13, 2025
Merged

reuse 5.0.2 (new formula) #206960

merged 2 commits into from
Feb 13, 2025

Conversation

toobuntu
Copy link
Contributor

@toobuntu toobuntu commented Feb 8, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

There's some confusion about which license to include in the formula. Debian, Gentoo, Arch and Fedora are listing all licenses reported upstream; MacPorts only GPLv3+. Upstream says its source code is GPLv3+, and docs, configs, etc., are under different licenses. The program itself declares only GPLv3+.

# reuse --version
reuse, version 5.0.2

This program is free software: you can redistribute it and/or modify it under
the terms of the GNU General Public License as published by the Free Software
Foundation, either version 3 of the License, or (at your option) any later
version.

This program is distributed in the hope that it will be useful, but WITHOUT
ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.

You should have received a copy of the GNU General Public License along with
this program. If not, see <https://www.gnu.org/licenses/>.

ref README

# curl --silent --location --url "https://raw.githubusercontent.com/fsfe/reuse-tool/refs/heads/main/README.md" | sed -n '/## Licens/,$ p'
## Licensing

This work is licensed under multiple licences. Because keeping this section
up-to-date is challenging, here is a brief summary as of April 2024:

- All original source code is licensed under GPL-3.0-or-later.
- All documentation is licensed under CC-BY-SA-4.0.
- Some configuration and data files are licensed under CC0-1.0.
- Some code borrowed from
  [spdx/tools-python](https://github.com/spdx/tools-python) is licensed under
  Apache-2.0.

For more accurate information, check the individual files.

ref Debian

# curl --silent --location --url "https://metadata.ftp-master.debian.org/changelogs//main/r/reuse/reuse_5.0.2-1_copyright" | grep -F "License: " | sort --unique
License: Apache-2.0
License: CC-BY-SA-4.0
License: CC0-1.0
License: GPL-3.0-or-later
License: GPL-3.0-or-later AND Apache-2.0

ref Gentoo

# curl --silent --location --url "https://gitweb.gentoo.org/repo/gentoo.git/plain/dev-util/reuse/reuse-5.0.2.ebuild" | grep -F "LICENSE="
LICENSE="GPL-3+ CC-BY-SA-4.0 CC0-1.0 Apache-2.0"

ref Arch

# curl --silent --location --url "https://gitlab.archlinux.org/archlinux/packaging/packages/reuse/-/raw/main/PKGBUILD" | sed -n '/^license=(/,/)/p'
license=(
  'Apache-2.0'
  'CC-BY-SA-4.0'
  'CC0-1.0'
  'GPL-3.0-or-later'
)

ref Fedora

# curl --silent --location --url "https://src.fedoraproject.org/rpms/reuse/raw/rawhide/f/reuse.spec" | awk '/^Summary:/{found=1} found && !/^Summary:/{print} /^License:/{exit}'
# The CC0-1.0 licence applies to json data files, not code.
# CC-BY-SA-4.0 is applied to documentation.
License:        Apache-2.0 AND CC0-1.0 AND CC-BY-SA-4.0 AND GPL-3.0-or-later

ref MacPorts

# curl --silent --location --url "https://raw.githubusercontent.com/macports/macports-ports/refs/heads/master/devel/reuse/Portfile" | sed -n '/^license/p'
license             GPL-3+

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Feb 8, 2025
@SMillerDev
Copy link
Member

Please stop creating new pull requests for every change, just push your changes to the same branch and the pull request will update.

@toobuntu
Copy link
Contributor Author

toobuntu commented Feb 8, 2025

Sorry, that's my bad. The bot kept adding unrelated commits (presumably rebasing?) when I force pushed and I couldn't figure out how to stop that and keep my branch clean.

@SMillerDev
Copy link
Member

Judging by the timeline the bot only ever added labels. Are you sure you weren't rebasing your work on the wrong branch?

@toobuntu
Copy link
Contributor Author

toobuntu commented Feb 9, 2025

Judging by the timeline the bot only ever added labels. Are you sure you weren't rebasing your work on the wrong branch?

Not sure anymore. It's definitely possible my workflow was wrong.
Screenshot 2025-02-08 at 9 29 45 PM

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Feb 9, 2025
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Feb 9, 2025
@toobuntu toobuntu force-pushed the fsfe/reuse branch 2 times, most recently from 934f7ef to c45f764 Compare February 9, 2025 19:34
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Feb 10, 2025
@toobuntu toobuntu marked this pull request as draft February 11, 2025 00:58
@toobuntu
Copy link
Contributor Author

Added shell completions. Should be ready now.

@toobuntu toobuntu marked this pull request as ready for review February 11, 2025 00:59
Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
Co-authored-by: Rui Chen <rui@chenrui.dev>
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Feb 12, 2025
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 13, 2025
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 13, 2025
Merged via the queue into Homebrew:master with commit 5a46aba Feb 13, 2025
15 checks passed
@toobuntu toobuntu deleted the fsfe/reuse branch February 13, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump automerge-skip `brew pr-automerge` will skip this pull request CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants