Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashing: fix sha256 sum of testdata #47842

Closed
wants to merge 1 commit into from
Closed

dashing: fix sha256 sum of testdata #47842

wants to merge 1 commit into from

Conversation

iwittkau
Copy link
Contributor

@iwittkau iwittkau commented Dec 13, 2019 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

related to #47510

@beauhoyt
Copy link

Looks like this just failed to checkout master branch to merge? 🤔
Is there an easy way to restart this test?

15:58:14 FATAL: Could not checkout 78640ef74c354516234e0e5fc8ff97f8e1e0e310
15:58:14 hudson.plugins.git.GitException: Command "git checkout -f 78640ef74c354516234e0e5fc8ff97f8e1e0e310" returned status code 128:
15:58:14 stdout: 
15:58:14 stderr: fatal: reference is not a tree: 78640ef74c354516234e0e5fc8ff97f8e1e0e310
15:58:14 
15:58:14 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)
15:58:14 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$1000(CliGitAPIImpl.java:80)
15:58:14 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$9.execute(CliGitAPIImpl.java:2681)
15:58:14 Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from 199.7.167.130/199.7.167.130:31118
15:58:14 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1743)
15:58:14 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)
15:58:14 		at hudson.remoting.Channel.call(Channel.java:957)
15:58:14 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)
15:58:14 		at sun.reflect.GeneratedMethodAccessor356.invoke(Unknown Source)
15:58:14 		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
15:58:14 		at java.lang.reflect.Method.invoke(Method.java:498)
15:58:14 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)
15:58:14 		at com.sun.proxy.$Proxy89.execute(Unknown Source)
15:58:14 		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1195)
15:58:14 		at hudson.scm.SCM.checkout(SCM.java:504)
15:58:14 		at hudson.model.AbstractProject.checkout(AbstractProject.java:1209)
15:58:14 		at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
15:58:14 		at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
15:58:14 		at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
15:58:14 		at hudson.model.Run.execute(Run.java:1816)
15:58:14 		at hudson.matrix.MatrixRun.run(MatrixRun.java:153)
15:58:14 		at hudson.model.ResourceController.execute(ResourceController.java:97)
15:58:14 		at hudson.model.Executor.run(Executor.java:429)
15:58:14 Caused: hudson.plugins.git.GitException: Could not checkout 78640ef74c354516234e0e5fc8ff97f8e1e0e310
15:58:14 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$9.execute(CliGitAPIImpl.java:2705)
15:58:14 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)
15:58:14 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)
15:58:14 	at hudson.remoting.UserRequest.perform(UserRequest.java:212)
15:58:14 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
15:58:14 	at hudson.remoting.Request$2.run(Request.java:369)
15:58:14 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
15:58:14 	at java.util.concurrent.FutureTask.run(FutureTask.java:264)
15:58:14 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
15:58:14 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
15:58:14 	at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:93)
15:58:14 	at java.lang.Thread.run(Thread.java:830)
15:58:14 Recording test results
15:58:14 ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?

@chenrui333
Copy link
Member

It would be good to have your base branch up to date (so that you dont have merge branch issue).

Thanks again for pushing go 1.13.5 forward.

@iwittkau
Copy link
Contributor Author

Hmm, I think I did some mistakes in my fork setup. 😞
I have to keep the master updated, and beaches for every PR, right?

@iwittkau
Copy link
Contributor Author

Oh, great the forumla has other build errors.

@iwittkau iwittkau mentioned this pull request Dec 14, 2019
Closed
@beauhoyt
Copy link

technosophos/dashing#53

Looks like they're removing dependencies for glide and moving go modules like everyone should. ;)

@iwittkau
Copy link
Contributor Author

Let's hope this gets merged quickly.

@beauhoyt
Copy link

@iwittkau the removal of glide and replacement with go modules got merged can we trigger this jenkins build again.

@iwittkau
Copy link
Contributor Author

@BrewTestBot test this please

@iwittkau
Copy link
Contributor Author

We need to update dashing to the latest version as well.

@SMillerDev
Copy link
Member

Why did the shasum change? Does upstream ruby know about this?

@iwittkau
Copy link
Contributor Author

iwittkau commented Dec 17, 2019 •
edited
Loading

Good point, didn't really think about it. Seems like documenting-ruby.org and ruby-doc.org are unofficial community efforts?

@iwittkau
Copy link
Contributor Author

Maybe because of https://www.ruby-lang.org/en/news/2019/10/01/webrick-regexp-digestauth-dos-cve-2019-16201/ docs for 2.5.0 got rebuild?

@SMillerDev
Copy link
Member

Whatever it is, please make sure it was intentional

@iwittkau
Copy link
Contributor Author

Mentioned it in technosophos/dashing#54, we still need a new version of dashing anyway.

@beauhoyt
Copy link

beauhoyt commented Dec 17, 2019 •
edited
Loading

@SMillerDev the ruby doc is just a resource to test against not part of the actual program and will be thrown away after the build... as far as a security concern i dont think this is one. Actually do we even need to be checksum this file - isn't it a little overkill in this context?

The site doesn't provide hash to compare against https://ruby-doc.org/downloads/ so no way of knowing either when something changes or gets updated or fixed.

@SMillerDev
Copy link
Member

I see what it does and why it's not a big security issue, but it might be better to validate and/or pick a stable resource all the same.

@iwittkau
Copy link
Contributor Author

Closing this because the whole dashing formula needs to be updated:

  • bump version to 0.4.0
  • remove glide dependency
  • rewrite install section
  • fix the test

Fixing the sha sum might speed up #47510, but I don't know how to verify the changed sha sum.

@iwittkau iwittkau closed this Dec 18, 2019
@iwittkau iwittkau mentioned this pull request Dec 18, 2019
Closed
5 tasks
@lock lock bot added the outdated PR was locked due to age label Jan 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iwittkau @beauhoyt @chenrui333 @SMillerDev