Move to go module, fix cli package reference #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests #50 and #52 opened up a can of worms:
You are now using
github.com/urfave/cli
v2.0.0 but this is not reflected in the glide files, so for instance I have a hard time updating the MacPorts port because it's no longer clear what your dependencies are pinned toTrying to update the glide files fails because, as best I can tell, some dependencies have moved to the modern go module system, and glide can't understand it:
The only reasonable solution seems to be moving this project to go modules as well. In that case, the import for
github.com/urfave/cli
needs to be corrected to"github.com/urfave/cli/v2"
.This PR moves to the go module system and fixes the import path. I did it by
go mod init
, which knows how to migrate from glidego mod tidy