Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ucl: aarch64 build fix #67716

Merged
merged 1 commit into from
Dec 26, 2020
Merged

ucl: aarch64 build fix #67716

merged 1 commit into from
Dec 26, 2020

Conversation

zeha
Copy link
Contributor

@zeha zeha commented Dec 26, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Fixes building on M1. Dependency of upx, which also builds fine after this fix.

@zeha
Copy link
Contributor Author

zeha commented Dec 26, 2020

Without the change, I get:

2020-12-26 01:58:52 +0100

./configure
--disable-debug
--disable-dependency-tracking
--prefix=/opt/homebrew/Cellar/ucl/1.03

configure: Configuring UCL 1.03
checking build system type... configure: error: /bin/sh acconfig/config.sub -apple-darwin20.2.0 failed

HOMEBREW_VERSION: 2.7.0-100-gda0d7ef
ORIGIN: https://github.com/Homebrew/brew
HEAD: da0d7eff9b19368735c569f5dafd8490fdd4a4c2
Last commit: 4 hours ago
Core tap ORIGIN: git@github.com:Homebrew/homebrew-core.git
Core tap HEAD: 25f0ba368ff54e5e114021796da7d5d8e11dcdb1
Core tap last commit: 74 seconds ago
Core tap branch: master
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_EDITOR: vim
HOMEBREW_MAKE_JOBS: 8
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: octa-core 64-bit arm_firestorm_icestorm
Clang: 12.0 build 1200
Git: 2.29.2 => /opt/homebrew/bin/git
Curl: 7.64.1 => /usr/bin/curl
macOS: 11.1-arm64
CLT: 12.3.0.0.1.1607026830
Xcode: 12.3
Rosetta 2: false

HOMEBREW_CC: clang
HOMEBREW_CXX: clang++
CFLAGS: -Wno-implicit-function-declaration
MAKEFLAGS: -j8
CMAKE_PREFIX_PATH: /opt/homebrew
CMAKE_INCLUDE_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers
CMAKE_LIBRARY_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries
PKG_CONFIG_LIBDIR: /usr/lib/pkgconfig:/opt/homebrew/Library/Homebrew/os/mac/pkgconfig/11.1
HOMEBREW_GIT: git
HOMEBREW_SDKROOT: /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk
ACLOCAL_PATH: /opt/homebrew/share/aclocal
PATH: /opt/homebrew/Library/Homebrew/shims/mac/super:/usr/bin:/bin:/usr/sbin:/sbin

@zeha
Copy link
Contributor Author

zeha commented Dec 26, 2020

10.15 test failed with:

==> Running Formulae#detect_formulae!
==> git -C /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core fetch origin +refs/heads/master
==> FAILED
fatal: unable to access 'https://github.com/Homebrew/homebrew-core/': transfer closed with outstanding read data remaining

So maybe a retry would fix that.

def install
# Workaround for ancient ./configure file
# Normally it would be cleaner to run "autoremake" to get a more modern one,
# but the tarball doesn't seem to include all of the local m4 files that were used
ENV.append "CFLAGS", "-Wno-implicit-function-declaration"
# Workaround for ancient config.sub files not recognising aarch64 macos.
# As above, autoremake would be nicer, but that does not work.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another potential fix is to just copy in a modern config.* yourself; see how I solved this problem in ssldump.rb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is exactly what is done here. I do not understand your comment, please explain.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my apologies, I misread the change. Not enough coffee or something

@fxcoudert
Copy link
Member

Repushing, as this should trigger a new build with ARM in our CI

@zeha
Copy link
Contributor Author

zeha commented Dec 26, 2020

A successful 11-arm CI run is there now :)

@fxcoudert
Copy link
Member

Actually since there is no existing bottle, this did not run on ARM CI.

@fxcoudert fxcoudert merged commit b092958 into Homebrew:master Dec 26, 2020
This was referenced Dec 26, 2020
@BrewTestBot
Copy link
Member

@fxcoudert bottle request for upx failed.

@mitchblank
Copy link
Contributor

@fxcoudert bottle request for upx failed.

upx isn't going to pass until upx/upx#424 is fixed... or did you mean to rebottle ucl instead?

@fxcoudert
Copy link
Member

@mitchblank no I really meant upx. Can't blame me for trying, ok? :)

@zeha zeha deleted the ucl-aarch64 branch December 27, 2020 00:55
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 27, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants