-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ucl: aarch64 build fix #67716
ucl: aarch64 build fix #67716
Conversation
Without the change, I get:
|
10.15 test failed with:
So maybe a retry would fix that. |
def install | ||
# Workaround for ancient ./configure file | ||
# Normally it would be cleaner to run "autoremake" to get a more modern one, | ||
# but the tarball doesn't seem to include all of the local m4 files that were used | ||
ENV.append "CFLAGS", "-Wno-implicit-function-declaration" | ||
# Workaround for ancient config.sub files not recognising aarch64 macos. | ||
# As above, autoremake would be nicer, but that does not work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another potential fix is to just copy in a modern config.*
yourself; see how I solved this problem in ssldump.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which is exactly what is done here. I do not understand your comment, please explain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my apologies, I misread the change. Not enough coffee or something
7a85ee9
to
a41740e
Compare
Repushing, as this should trigger a new build with ARM in our CI |
A successful 11-arm CI run is there now :) |
Actually since there is no existing bottle, this did not run on ARM CI. |
❌ @fxcoudert bottle request for upx failed. |
|
@mitchblank no I really meant upx. Can't blame me for trying, ok? :) |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?Fixes building on M1. Dependency of
upx
, which also builds fine after this fix.