Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests.yml: add CI-force-arm label #67760

Merged
merged 1 commit into from
Dec 26, 2020
Merged

Conversation

fxcoudert
Copy link
Member

Improving #67577 so that ARM CI behaves as follows:

  • by default, only test formulas that already have an ARM bottle
  • if CI-force-arm flag is found, run ARM CI in all cases

The problem with the current approach is that we're not allowing to test new fixes for ARM. Take this PR #67716 or this one #67758, they would need to run on ARM to test the fix being introduced, but they're not. We need a way to opt-in to ARM testing for a given PR.

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Dec 26, 2020
@fxcoudert
Copy link
Member Author

fxcoudert commented Dec 26, 2020

The tap_syntax test never runs… weird

I have no idea whether this is expected or not, so I'll merge this to test in other PRs…

@fxcoudert fxcoudert merged commit 511150c into Homebrew:master Dec 26, 2020
fxcoudert added a commit that referenced this pull request Dec 26, 2020
fxcoudert added a commit to fxcoudert/homebrew-core that referenced this pull request Dec 26, 2020
@fxcoudert
Copy link
Member Author

OK so it was (silently) not running because the workflow was invalid. Don't know why it doesn't like the ! operator…

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 26, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants