samba 4.14.5 (new formula)

[AkihiroSuda]

Samba (v3) was removed from Homebrew in 2016 due to technical issues (Homebrew/legacy-homebrew#17820, 5af93ae), however, Samba v4 seems actively supporting macOS recently, and worth including again in Homebrew.

Samba v4 is already included in MacPorts.

Further discussion in Homebrew/discussions#1736

The formula is based on Alexander Richardson (@arichardson)'s PR #32031 .

Example usage with qemu:

qemu-system-x86_64 \
  -accel hvf \
  -m 4096 \
  -cdrom ubuntu-21.04-desktop-amd64.iso \
  -net nic \
  -net user,smb=/tmp/foo

The shared folder can be mounted with mount.cifs //10.0.2.4/qemu /mnt in the guest.

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[AkihiroSuda]

cc @arichardson @fxcoudert

[SMillerDev]

This means the formulae should be keg-only instead of renaming IYAM

[AkihiroSuda]

QEMU requires the binary to be renamed:

homebrew-core/Formula/qemu.rb

Lines 67 to 72 in 0b1849e

	# Sharing Samba directories in QEMU requires the samba.org smbd which is
	# incompatible with the macOS-provided version. This will lead to
	# silent runtime failures, so we set it to a Homebrew path in order to
	# obtain sensible runtime errors. This will also be compatible with
	# Samba installations from external taps.
	args << "--smbd=#{HOMEBREW_PREFIX}/sbin/samba-dot-org-smbd"

[arichardson]

I think it should also be fine if it's called smbd but is inside a separate directory (i.e. not linked to /usr/local/sbin). I believe the reason I used a separate name was to make the error message more obvious.

[SMillerDev]

QEMU requires the binary to be renamed

I think if we ship samba again we can just update the qemu formula

[carlocab]

I think if we ship samba again we can just update the qemu formula

Let's not do this. This breaks the install of anyone using a non-Homebrew Samba with Homebrew QEMU. Personally I think renaming one file to avoid a conflict is perfectly fine. We have a lot of formulae that do more than this to avoid becoming keg-only too. (e.g. the versioned gcc formulae)

[SMillerDev]

Maybe we can symlink it?

[AkihiroSuda]

macOS version of smbd is completely different from Samba version of smbd except the binary name.

So I think renaming the binary without making it keg-only is more preferable than symlinking keg-only binary.

[carlocab]

You have some errors from brew audit --new. Please don't mark items in the PR template as done when you did not do them.

[arichardson]

Is the groups_max patch no longer required? I don't see any changes to that function upstream. Without it samba fails if you are in more than 16 groups.

[arichardson]

Thanks for working on this, will be great to have a binary package rather than having to build from source :)
For the Co-authored-by, you can use the following email: Co-authored-by: Alex Richardson <Alexander.Richardson@cl.cam.ac.uk>

[AkihiroSuda]

Updated PR to use custom CFLAGS instead of applying patches, for avoiding Formulae should not require patches to build. Patches should be submitted and accepted upstream first. error.

Also added caveats to print the binary path ("/usr/local/sbin/samba-dot-org-smbd") and suggest running Samba as non-root.

[carlocab]

This feels like a pretty heavy-handed way of getting around the no-patches requirement.

[BrewTestBot]

@carlocab has triggered a merge.