samba: avoid conflicting with /usr/bin/{mdfind,profiles} #81592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
reviewed
Jul 21, 2021
carlocab
reviewed
Jul 21, 2021
carlocab
reviewed
Jul 21, 2021
AkihiroSuda
force-pushed
the
fix-samba-mdfind-profiles-conflict
branch
2 times, most recently
from
62ac921 to
5212fc3
Compare
Applying this patch is enough? https://attachments.samba.org/attachment.cgi?id=16579 (from https://bugzilla.samba.org/show_bug.cgi?id=14680 )
Thanks, updated |
AkihiroSuda
force-pushed
the
fix-samba-mdfind-profiles-conflict
branch
from
5212fc3 to
52a5105
Compare
|
The patch is fine. It'll be easier to notice that it needs removing anyway. Please indicate in a comment when the patch can be removed. |
carlocab
reviewed
Jul 21, 2021
AkihiroSuda
force-pushed
the
fix-samba-mdfind-profiles-conflict
branch
from
52a5105 to
c9b75cd
Compare
Rename samba version of {mdfind,profiles} to samba-dot-org-{mdfind,profiles}
to avoid conflicting with macOS systemd binaries /usr/bin/{mdfind,profiles}
The "samba-dot-org-" prefix corresponds to samba-dot-org-smbd.
Also remove custom CFLAGS.
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
fix-samba-mdfind-profiles-conflict
branch
from
c9b75cd to
c6588bd
Compare
SMillerDev
approved these changes
Jul 22, 2021
|
🤖 A scheduled task has triggered a merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename samba version of
{mdfind,profiles}tosamba-dot-org-{mdfind,profiles}to avoid conflicting with macOS systemd binaries/usr/bin/{mdfind,profiles}The "samba-dot-org-" prefix corresponds to
samba-dot-org-smbd.Also remove custom
CFLAGS.Follow-up to #80171
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?