Redact Google Test

[adamv]

From 1.6.0:

echo "'make install' is dangerous and not supported. Instead, see README for how to integrate Google Test into your build system."
test -z "/Users/adamv/homebrew/Cellar/gtest/1.6.0/lib" || build-aux/install-sh -c -d "/Users/adamv/homebrew/Cellar/gtest/1.6.0/lib"
'make install' is dangerous and not supported. Instead, see README for how to integrate Google Test into your build system.

[MikeMcQuaid]

+1

[2bits]

I don't get this. gtest-1.6.0 README says to use CMake. It then only creates two libraries and some includes.

libgtest.a
libgtest_main.a
include/gtest/*

Why would you redact the formula instead of fixing it? I got it to work easily enough, and I got flann to build.

[jacknagel]

http://code.google.com/p/googletest/wiki/FAQ#Why_is_it_not_recommended_to_install_a_pre-compiled_copy_of_Goog

[mistydemeo]

@Sharpie flann depends on a prebuild gtest for some of its tests. Is it important enough that we should provide a private gtest subformula in flann to make sure it can run those tests? It can build without.

See #14126

[Sharpie]

Is it important enough that we should provide a private gtest subformula in flann to make sure it can run those tests?

According to the info Jack linked to, it looks like gtest should be built with exactly the same flags as the rest of the software---i.e. integrated into the buildsystem for each project.

Because of this, I don't think adding a subformula will completely sidestep the issue. Probably the best we can do is pull the gtest dependency and kick this upstream to the flann project so that they can take the proper steps.

[mistydemeo]

Removed flann's dep on gtest in b0ecaaa