-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace gtest with sytem version #731
Conversation
jspricke
commented
Jun 8, 2014
- Add new FindGtest.cmake to find installed versions.
- Add libgtest-dev for Travis
- Add new FindGtest.cmake to find installed versions. - Add libgtest-dev for Travis
Works well on my machine. Seems that on Travis everything is fine also. Shall we wait for someone on Mac to comment? |
Yes, @gcasey can you do this? |
Yes I will test this evening. |
Neither macports nor homebrew provide a system version of gtest for the reasons mentioned in the google test FAQ (to ensure tests are compiled with identical compiler flags) https://trac.macports.org/ticket/35540 I could manually compile the package on mac and test, but I believe that we should stick with embedded version of gtest. This will also make testing easier for windows developers. Other projects embedding gtest source code |
On 9. Juni 2014 16:37:35 MESZ, Casey Goodlett notifications@github.com wrote:
Neither does Debian, they only packaged the source. It should be enough to download the GTest source and add a -DGTEST_DIR=path to cmake. |
ok. I misunderstood based on the modification to the travis file. I pointed my mac ( mavericks + xcode 5.1.1 ) build to the gtest source code by specifying GTEST_SRC_DIR and GTEST_INCLUDE_DIR during ccmake. I was able to build and run tests successfully. This looks good to me. Thanks |
Replace gtest with sytem version (closes #717)
@gcasey thanks for testing, it should work by only setting GTEST_ROOT, sorry for mixing that up. |