Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slang proof of concept #4

Merged
merged 32 commits into from
Sep 5, 2024
Merged

Slang proof of concept #4

merged 32 commits into from
Sep 5, 2024

Conversation

Honeybunch
Copy link
Collaborator

No description provided.

Honeybunch added 30 commits May 5, 2024 14:06
@Honeybunch
Slang proof of concept
6a7a4f4
@Honeybunch
Testing Custom slang port work
8c7ae6a
@Honeybunch
Trying to fix slang port again
1943eb3
@Honeybunch
Fixing path to shaderc
44d6088
@Honeybunch
Updating shader-slang port again
c2b37e4
@Honeybunch
Updating shader slang port to fix macos
91bfe2c
@Honeybunch
Making sure more slangc deps are copied properly
0dade75
@Honeybunch
Another slang update and an attempt to fix
faa7b95
@Honeybunch
More attempted fixes
10784c3
@Honeybunch
Updating port for macos again
b9adc25
@Honeybunch
Another macos attempt
8e6dec7
@Honeybunch
Another port patch for slang
4293a91
@Honeybunch
Might work after slangc gets patched
9c873be
@Honeybunch
Updating slang port
f57d66c
@Honeybunch
Merge remote-tracking branch 'origin' into slang
0158274
@Honeybunch
Making progress on getting a working gltf shader from slang
39363d2
@Honeybunch
Merge branch 'main' into slang
0deecc0
@Honeybunch
Trying newer version of slang
8ff3e3d
@Honeybunch
Slang actually works for gltf now
1d633d8
@Honeybunch
Moving sky shader to slang
f0759e8
@Honeybunch
Bistro works
920f838
@Honeybunch
Ocean works though something causes the ocean demo to not rendering t…
d3f3d1f 
…he sky. Unsure why
@Honeybunch
Making sure resources are packed properly
58a9061
@Honeybunch
Pedantic Warning fix
aed57b7
@Honeybunch
Trying to fix up linux workflow
2ab822e
@Honeybunch
Trying to fix linux workflow and cmake preset env var nonsense
0c44632
@Honeybunch
Trying to fix cmake presets
35bac79
@Honeybunch
Trying to fix cmake presets again this time by making sure to expliti…
7b60cad 
…cly use penv rather than env
@Honeybunch
Making sure to penv android ndk
1dd5e45
@Honeybunch
Another different way of trying to specify VCPKG_ROOT for linux
8491ee0
@Honeybunch Honeybunch mentioned this pull request Sep 3, 2024
Merged
7 tasks
@Honeybunch Honeybunch merged commit f97b72f into main Sep 5, 2024
11 checks passed
@Honeybunch Honeybunch deleted the slang branch September 5, 2024 21:10
ColdenCullen
ColdenCullen reviewed Sep 5, 2024
View reviewed changes
include/tb_gltf.slangh

#define ALPHA_CUTOFF(m) m.sheen_alpha.w

#if defined(TB_SHADER) && !defined(TB_SHADER)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will never be true... right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good catch that's an artifact that can be destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColdenCullen ColdenCullen ColdenCullen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Honeybunch @ColdenCullen