Respond with 401 for request non-HTML requests #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Houdini
added a commit
that referenced
this pull request
Jan 10, 2013
Respond with 401 for request non-HTML requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Houdini can you take at the solution? Is it missing something important?
Responding with empty body and just 401 status is pretty lame. It's a catch-all so neither plain text "Failed second factor auth" nor JSON "{message: "Failed second factor auth"} seems appropriate. I think that's ok because easily override handle_failed_second in your ApplicationController to fit your needs.