Login Page: Add quote and link to presentation website #261 #265

christianeiselt · 2018-09-13T19:50:49Z

close #261

roschaefer · 2018-09-13T19:55:57Z

pages/auth/login.vue

@@ -12,6 +12,8 @@
 <img src="/assets/images/registration/humanconnection.svg" alt="Human Connection"/>
 </nuxt-link>
 </div>
+ <p class="subtitle is-6">Viele kleine Leute, die in vielen kleinen Orten viele kleine Dinge tun, können das Gesicht der Welt verändern.</p>
+ <p class="subtitle is-7">Afrikanisches Sprichwort</p>


@christianeiselt please translate this quote

appinteractive · 2018-09-14T06:32:18Z

What about an English Version?

christianeiselt · 2018-09-14T10:07:54Z

Deutsch: Viele kleine Leute, die in vielen kleinen Orten viele kleine Dinge tun, können das Gesicht der Welt verändern. - Afrikanisches Sprichwort
English: Many small people, who in many small places do many small things, that can alter the face of the world.
Mögliches Original: Viele kleine Leute, an vielen kleinen Orten, die viele kleine Dinge tun, werden das Antlitz dieser Welt verändern. - Sprichwort der Xhosa

roschaefer · 2018-09-14T12:49:36Z

locales/de.json

+ },
+ "quotes": {
+ "1": {
+ "quoteTxt": "Viele kleine Leute, die in vielen kleinen Orten viele kleine Dinge tun, können das Gesicht der Welt verändern.",


I love the Xhosa original!

I'd prefer that 😉

roschaefer · 2018-09-14T12:51:06Z

pages/auth/login.vue

@@ -68,6 +68,8 @@
 {{ $t('auth.login.label') }}
 </hc-button>
 </form>
+ <p class="subtitle is-6">{{ $t('quotes.1.quoteTxt') }}</p>
+ <p class="subtitle is-7">{{ $t('quotes.1.quoteAuthor') }}</p>


@christianeiselt can we remove the 1? Just $t('quotes.quoteText')? Or if you want to add more quotes: $t('quotes.faceOfTheWorld.quoteTxt')?

Is the goal to have only this one quote? Then $t('quotes.quoteText') will be good enough, of course.
I used the number because I thought the goal would be to display a random quote and I'd say it will be difficult to come up for a shortname for every quote... But the number is static and therefore still not good for manual inserts.

Also decreases the "padding-top" value of the quote author paragraph. This needs attention as I only found a way by setting the style directly to this div container.

christianeiselt · 2018-09-16T17:57:56Z

pages/auth/login.vue

- <p class="subtitle is-7">{{ $t('quotes.african.author') }}</p>
+ <p class="subtitle is-6">
+ {{ $t('quotes.african.txt') }}
+ <div style="padding-top: 10px">


This is dirty... Can somebody point me to the right css class or where to create a new one for this purpose?
@roschaefer

Sure, just take a look at the other components. You can add a class name on the element and then style it inside the style tag on the component or page.

That is the current status.

Sure, just take a look at the other components. You can add a class name on the element and then style it inside the style tag on the component or page.

Yeah, that's what I tried. But when I add .subtitle.is-8 as a copy of .subtitle.is-7 plus the additional padding-top: 10px; and change the class in the login.vue to subtitle is-8, it is not recognized and will be displayed with default style...

Actually, I just need to know, which stylesheet I need to manipulate, because there's so many of them...

Okay, I see that you are using div elements inside of p, that’s not valid. Try to use span instead.

And the Stylesheet is inside of the component you are workin on. Ignore everything inside the node modules folder. That are third party styles that not all are applied.

When you are searching for global styles, the are not .css but .scss files. The local styles live inside the .vue files then selve in an Style Tag. See https://vuejs.org/v2/guide/single-file-components.html

I would stick with local styling in this case or see the https://bulma.io documentation for the available styles.

@christianeiselt

@christianeiselt see here: https://bulma.io/documentation/modifiers/typography-helpers/ https://bulma.io/documentation/modifiers/color-helpers/

roschaefer · 2018-09-17T16:38:27Z

@christianeiselt I think you can remove [WIP] from the title. This is very cool. I fixed small things and added a hint in the commit message.
@appinteractive this is good to go I would say. I find it odd that the text is below the login field. Can we at least move up the paragraph "Hier gehts zur Präsentationswebsite"?

roschaefer · 2018-09-17T16:39:55Z

@appinteractive the footer looks terrible on mobile btw

appinteractive · 2018-09-17T18:02:28Z

@roschaefer I have spoken with Sabine about that, I think we will redesign the login anyway in the direction like these: https://dribbble.com/shots/3829284-Dipnet-login-page

From the hierarchy, the first think should be the login form like before and after that the further info. On desktop we should put the infos on the site where we can add more info’s. But this should go into an separate issue.

christianeiselt · 2018-09-17T19:59:48Z

Alright, I removed the WIP. Thanks for the input, y'all!

roschaefer · 2018-09-17T20:39:26Z

@appinteractive would it be OK to merge this anyway? I bet, @christianeiselt would love to become a part of https://github.com/Human-Connection/WebApp/graphs/contributors

appinteractive · 2018-09-17T20:43:20Z

Sure, would be glad to see another new face there! But could you open a follow up issue on for this? Or maybe even a project for login & registration?

roschaefer · 2018-09-17T21:31:51Z

Ok, everybody, I hit "merge" now. I find it odd to have the text below but anyways.. 🤷‍♂️

@christianeiselt congrats to your first code contribution to Human Connection 🎉 🎈 🤗

christianeiselt · 2018-09-17T22:18:34Z

Thanks! I‘m glad, that I can help! On 17. Sep 2018, at 23:31, Robert Schäfer <notifications@github.com> wrote: Ok, everybody, I hit "merge" now. I find it odd to have the text below but anyways.. 🤷‍♂️ @christianeiselt congrats to your first code contribution to Human Connection 🎉 🎈 🤗 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Lulalaby · 2018-09-17T22:29:20Z

Well done @christianeiselt 😉.

Add motivating african quote to login

8522c50

roschaefer reviewed Sep 13, 2018

View reviewed changes

Add quotes as variable text snippets

7f18c6c

roschaefer reviewed Sep 14, 2018

View reviewed changes

christianeiselt added 3 commits September 14, 2018 16:06

Change the african quote to the xhosa one

bf74dde

Change quote key reflecting region

7d0ff58

Add text and link to presentation

f64954a

Also decreases the "padding-top" value of the quote author paragraph. This needs attention as I only found a way by setting the style directly to this div container.

christianeiselt commented Sep 16, 2018

View reviewed changes

christianeiselt and others added 2 commits September 16, 2018 22:01

Translate presentation text to EN

9c45420

Fix translations, use bulmas css for styling

37af8a0

@christianeiselt see here: https://bulma.io/documentation/modifiers/typography-helpers/ https://bulma.io/documentation/modifiers/color-helpers/

christianeiselt changed the title ~~[WIP] Login Page: Add quote and link to presentation website #261~~ Login Page: Add quote and link to presentation website #261 Sep 17, 2018

ghost mentioned this pull request Sep 17, 2018

Login Page: Add quote and link to presentation website #261

Closed

roschaefer merged commit 54f6c59 into Human-Connection:develop Sep 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Login Page: Add quote and link to presentation website #261 #265

Login Page: Add quote and link to presentation website #261 #265

christianeiselt commented Sep 13, 2018

roschaefer Sep 13, 2018

appinteractive commented Sep 14, 2018 •

edited

Loading

christianeiselt commented Sep 14, 2018

roschaefer Sep 14, 2018

roschaefer Sep 14, 2018

roschaefer Sep 14, 2018 •

edited

Loading

christianeiselt Sep 14, 2018 •

edited

Loading

christianeiselt Sep 16, 2018

appinteractive Sep 16, 2018

christianeiselt Sep 16, 2018

christianeiselt Sep 16, 2018 •

edited

Loading

appinteractive Sep 16, 2018

appinteractive Sep 16, 2018 •

edited

Loading

roschaefer commented Sep 17, 2018

roschaefer commented Sep 17, 2018

appinteractive commented Sep 17, 2018

christianeiselt commented Sep 17, 2018

roschaefer commented Sep 17, 2018

appinteractive commented Sep 17, 2018

roschaefer commented Sep 17, 2018

christianeiselt commented Sep 17, 2018 via email

Lulalaby commented Sep 17, 2018 •

edited

Loading

Login Page: Add quote and link to presentation website #261 #265

Login Page: Add quote and link to presentation website #261 #265

Conversation

christianeiselt commented Sep 13, 2018

roschaefer Sep 13, 2018

Choose a reason for hiding this comment

appinteractive commented Sep 14, 2018 • edited Loading

christianeiselt commented Sep 14, 2018

roschaefer Sep 14, 2018

Choose a reason for hiding this comment

roschaefer Sep 14, 2018

Choose a reason for hiding this comment

roschaefer Sep 14, 2018 • edited Loading

Choose a reason for hiding this comment

christianeiselt Sep 14, 2018 • edited Loading

Choose a reason for hiding this comment

christianeiselt Sep 16, 2018

Choose a reason for hiding this comment

appinteractive Sep 16, 2018

Choose a reason for hiding this comment

christianeiselt Sep 16, 2018

Choose a reason for hiding this comment

christianeiselt Sep 16, 2018 • edited Loading

Choose a reason for hiding this comment

appinteractive Sep 16, 2018

Choose a reason for hiding this comment

appinteractive Sep 16, 2018 • edited Loading

Choose a reason for hiding this comment

roschaefer commented Sep 17, 2018

roschaefer commented Sep 17, 2018

appinteractive commented Sep 17, 2018

christianeiselt commented Sep 17, 2018

roschaefer commented Sep 17, 2018

appinteractive commented Sep 17, 2018

roschaefer commented Sep 17, 2018

christianeiselt commented Sep 17, 2018 via email

Lulalaby commented Sep 17, 2018 • edited Loading

appinteractive commented Sep 14, 2018 •

edited

Loading

roschaefer Sep 14, 2018 •

edited

Loading

christianeiselt Sep 14, 2018 •

edited

Loading

christianeiselt Sep 16, 2018 •

edited

Loading

appinteractive Sep 16, 2018 •

edited

Loading

Lulalaby commented Sep 17, 2018 •

edited

Loading