Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login Page: Add quote and link to presentation website #261 #265

Merged
merged 7 commits into from
Sep 17, 2018
Merged

Login Page: Add quote and link to presentation website #261 #265

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8522c50
Add motivating african quote to login
christianeiselt Sep 13, 2018
7f18c6c
Add quotes as variable text snippets
christianeiselt Sep 14, 2018
bf74dde
Change the african quote to the xhosa one
christianeiselt Sep 14, 2018
7d0ff58
Change quote key reflecting region
christianeiselt Sep 14, 2018
f64954a
Add text and link to presentation
christianeiselt Sep 16, 2018
9c45420
Translate presentation text to EN
christianeiselt Sep 16, 2018
37af8a0
Fix translations, use bulmas css for styling
roschaefer Sep 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions locales/de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,5 +629,11 @@
"created": "Erstellt",
"active": "Aktiviert",
"inactive": "Deaktiviert"
},
"quotes": {
"1": {
"quoteTxt": "Viele kleine Leute, die in vielen kleinen Orten viele kleine Dinge tun, können das Gesicht der Welt verändern.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the Xhosa original!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer that 😉

"quoteAuthor": "Afrikanisches Sprichwort"
}
}
}
6 changes: 6 additions & 0 deletions locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,5 +631,11 @@
"created": "Created",
"active": "Active",
"inactive": "Inactive"
},
"quotes": {
"1": {
"quoteTxt": "Many small people, who in many small places do many small things, that can alter the face of the world.",
"quoteAuthor": "African Saying"
}
}
}
2 changes: 2 additions & 0 deletions pages/auth/login.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@
{{ $t('auth.login.label') }}
</hc-button>
</form>
<p class="subtitle is-6">{{ $t('quotes.1.quoteTxt') }}</p>
<p class="subtitle is-7">{{ $t('quotes.1.quoteAuthor') }}</p>
Copy link
Contributor

@roschaefer roschaefer Sep 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christianeiselt can we remove the 1? Just $t('quotes.quoteText')? Or if you want to add more quotes: $t('quotes.faceOfTheWorld.quoteTxt')?

Copy link
Author

@christianeiselt christianeiselt Sep 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the goal to have only this one quote? Then $t('quotes.quoteText') will be good enough, of course.
I used the number because I thought the goal would be to display a random quote and I'd say it will be difficult to come up for a shortname for every quote... But the number is static and therefore still not good for manual inserts.

</div>
<footer class="card-footer">
<!--
Expand Down