357 update convergence criteria #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions and some tech debt nukage along the way
|
some weird changes came through in the test files, I am going to do a little more housecleaning |
|
I have identified the issue in the failing test, resolving shortly |
|
@Brennan1994 this is ready for your review. Thank you. |
Brennan1994
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change. We've played with convergence criteria for some time, but we're at the place now where it should just match 1.4.3. I think we'll have the option to revisit later.
Notice that convergence is different for EAD as it is for stage-damage. This is how 1.4.3 is wired.
I worked on some tech debt along the way - better aligning responsibilities, though still not perfect.