Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset filtering should use the patternfly design recommendation #1346

Closed
willr3 opened this issue Feb 19, 2024 · 0 comments · Fixed by #1797
Closed

Dataset filtering should use the patternfly design recommendation #1346

willr3 opened this issue Feb 19, 2024 · 0 comments · Fixed by #1797
Assignees
@johnaohara
Labels
area/UI priority/high High priority type/enhancement An enhancement to an existing feature

Comments

@willr3
Copy link
Collaborator

willr3 commented Feb 19, 2024

Feature idea.

Dataset filtering in the UI uses a drop down per filter option (labelName?) which can result in a long scrollable header of options

Screenshot from 2024-02-19 12-16-06

The Patternfly recommended approach is the attribute-search example in the filters component

https://www.patternfly.org/patterns/filters#attribute-search
@johnaohara johnaohara added type/enhancement An enhancement to an existing feature area/UI priority/high High priority labels Feb 20, 2024
This was referenced Feb 20, 2024
Open
Open
@johnaohara johnaohara self-assigned this Jun 15, 2024
@johnaohara johnaohara mentioned this issue Jun 16, 2024
Merged
johnaohara added a commit to johnaohara/Horreum that referenced this issue Jun 21, 2024
@johnaohara
Use 'attribute-search' UI pattern for dataset filters : Fixes Hyperfo…
4b811a1 
…il#1346
johnaohara added a commit to johnaohara/Horreum that referenced this issue Jun 22, 2024
@johnaohara
Use 'attribute-search' UI pattern for dataset filters : Fixes Hyperfo…
6e06872 
…il#1346
rh-appservices-perf pushed a commit that referenced this issue Jun 23, 2024
@johnaohara
Use 'attribute-search' UI pattern for dataset filters : Fixes #1346
5d806f2
@rh-appservices-perf rh-appservices-perf mentioned this issue Jun 23, 2024
Merged
johnaohara added a commit that referenced this issue Jun 23, 2024
@johnaohara
Use 'attribute-search' UI pattern for dataset filters : Fixes #1346
ab02692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnaohara johnaohara

Labels
area/UI priority/high High priority type/enhancement An enhancement to an existing feature
Projects
None yet
Milestone
No milestone
2 participants
@johnaohara @willr3