Change dataset filters to Patternfly Attribute Filter pattern: Fixes: #1346 #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnaohara
changed the title
lampajr
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Hey @johnaohara, this looks an awesome improvement in the UI ❤️
I left a couple of comments.
Comment on lines
+87
to
+90
| props.options.map((option) => ( | ||
| <MenuItem isSelected={props.selection === option} itemId={option} key={option}> | ||
| {option} | ||
| </MenuItem> |
There was a problem hiding this comment.
We need to filter out undefined options otherwise we would have null options (that are selected by default):
Suggested change
| props.options.map((option) => ( | |
| <MenuItem isSelected={props.selection === option} itemId={option} key={option}> | |
| {option} | |
| </MenuItem> | |
| props.options.filter(option => option).map((option) => ( | |
| <MenuItem isSelected={props.selection === option} itemId={option} key={option}> | |
| {option} | |
| </MenuItem> |
There was a problem hiding this comment.
The filter does remove undefined, but the api (maybe it is the json marshalling, idk atm) is returning a mixture of null and undefined, and it is the null values that are causing the issue.
Other LabelValues only return undefined for an unknown value.
My intention was to merge this PR as it is, and then fix the api problem that is returning the wrong data type for an unknown label value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the filter dropdown to use the Patternfly
attribute-searchpatternFixes Issue
Fixes: #1346
